Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove xlibsWrapper #194054

Closed
83 tasks done
trofi opened this issue Oct 2, 2022 · 1 comment
Closed
83 tasks done

Deprecate and remove xlibsWrapper #194054

trofi opened this issue Oct 2, 2022 · 1 comment

Comments

@trofi
Copy link
Contributor

trofi commented Oct 2, 2022

In #194044 I noticed unusual behaviour of xlibsWrapper when xorg is overridden. That PR handles override part.

But I think xlibsWrapper should just disappear. Where should be no reason (for example) for pulseaudio to depend on freetype at build time. xlibsWrapper is just the wrapper around a few libraries. Quoting pkgs/top-level/all-packages.nix:

  # Avoid using this. It isn't really a wrapper anymore, but we keep the name.
  xlibsWrapper = callPackage ../development/libraries/xlibs-wrapper {
    packages = [
      freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
      xorg.libXft xorg.libXext xorg.libSM xorg.libICE
    ];
  };

Mechanically we can replace xlibsWrapper with the list of packages it provides. Even better would be to audit needed libraries for each user and use only a subset of them.


Example fix:

More packages to fix:

Fixed packages:

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/1

LeSuisse added a commit to LeSuisse/nixpkgs that referenced this issue Oct 29, 2022
trofi added a commit to trofi/nixpkgs that referenced this issue Dec 27, 2022
There should be no reason to use this package as it's a remnant of
non-modular X. Chances are you do not want every single library it
used to pull in:

      freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
      xorg.libXft xorg.libXext xorg.libSM xorg.libICE

Just pick the ones you really need instead.

`nixpkgs` does not have any users of `xlibsWrapper`.

Closes: NixOS#194054
trofi added a commit to trofi/nixpkgs that referenced this issue Dec 27, 2022
There should be no reason to use this package as it's a remnant of
non-modular X. Chances are you do not want every single library it
used to pull in:

      freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
      xorg.libXft xorg.libXext xorg.libSM xorg.libICE

Just pick the ones you really need instead.

`nixpkgs` does not have any users of `xlibsWrapper`.

Closes: NixOS#194054
trofi added a commit to trofi/nixpkgs that referenced this issue Dec 27, 2022
There should be no reason to use this package as it's a remnant of
non-modular X. Chances are you do not want every single library it
used to pull in:

      freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
      xorg.libXft xorg.libXext xorg.libSM xorg.libICE

Just pick the ones you really need instead.

`nixpkgs` does not have any users of `xlibsWrapper`.

Closes: NixOS#194054
bors bot pushed a commit to bevyengine/bevy that referenced this issue Dec 29, 2022
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
simonkampe pushed a commit to simonkampe/poetry2nix that referenced this issue Jan 4, 2023
`xlibsWrapper` was a transitional package to move from monolithic
xorg package to modules. `nixpkgs` `python3Packages.pycairo` already
removed `pkgs.xlibsWrapper`. This change follow the same change.

Bug: NixOS/nixpkgs#194054
Closes: nix-community#863
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
# Objective

`xlibsWrapper` is being deprecated: NixOS/nixpkgs#194054, this pr removes the deprecated xlibsWrapper and makes a couple more improvements

## Solution

- rename NixOS to Nix since this is not specific to NixOS
- remove usage of `xlibsWrapper`
- add instructions for nix flakes with `nix develop`
- add example of a packaged bevy program in nixpkgs
- minor cosmetic/grammatical changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants