Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji-picker: init at 0.2.0 #200068

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

urandom2
Copy link
Contributor

@urandom2 urandom2 commented Nov 7, 2022

Description of changes

Fixes #191952

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1376

urandom2 added a commit to urandom2/ep that referenced this pull request Nov 8, 2022
There is a blocking go bug on darwin, golang/go#49219, that was hit
during NixOS/nixpkgs#200068. While we are updating things it seems
reasonable to bump everything.
There is an upstream bug with golang.org/x/sys, that requires we upgrade
to 0.1.0, and this change forces us to move the go minimum version to
1.17. All of this is done via patch, and can be rolled back when
upstream merges bcongdon/ep#7.

Fixes NixOS#191952
@SuperSandro2000 SuperSandro2000 merged commit 0ed8702 into NixOS:master Nov 8, 2022
@urandom2 urandom2 deleted the emoji-picker branch December 1, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-request: ep (Emoji Picker)
3 participants