-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/debug/internal/core: build broken on darwin since at least 2021-10-28 #49219
Comments
This is a release blocker for Go 1.18 via #11811. (CC @golang/release) |
The fix (in CL 359596) appears to be to upgrade the dependency on |
Change https://golang.org/cl/359596 mentions this issue: |
Change https://golang.org/cl/359595 mentions this issue: |
For golang/go#49219 Change-Id: Ia0ede89fcf365c3feef9d34ac5a6b379749c015e Reviewed-on: https://go-review.googlesource.com/c/debug/+/359595 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bcmills 👋🏼 I just ran into the above error when trying out go1.18beta1 running this program: https://go.dev/play/p/PVYJTCGE7ZU Let me know if this is a well known/fixed bug given the CLs mentioned, or if we should re-open this issue. Thanks! |
looks like this is not fixed in |
@AbhimanyuAryan, you may need to upgrade your |
Yes I fixed it thanks |
- Get rid of URL option and use default slack API url. - Add Token and Channels options - rename post method to postBody - move token from query params to header - render channels param for files.upload from options - add .idea to gitignore - upgrade golang.org/x/sys version due to build fail golang/go#49219
This picks up a new 2022 version of golang.org/x/sys which is caused by golang/go#49219 and is needed to fix building using Go 1.18 on aarch64-darwin.
Older versions of the transitive dependency golang.org/x/sys cannot be built on newer versions of Go for certain platforms. golang/go#49219
## Problem Build was failing on darwin/arm64. See [here](golang/go#49219). ## Solution We update the dependency on x/sys. ``` > go get -u golang.org/x/sys go: downloading golang.org/x/sys v0.0.0-20221010170243-090e33056c14 go: upgraded golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f => v0.0.0-20221010170243-090e33056c14 > go mod tidy ```
There is a blocking go bug on darwin, golang/go#49219, that was hit during NixOS/nixpkgs#200068. While we are updating things it seems reasonable to bump everything.
@bcmills would it be possible to create a new tag for |
Upgraded golang.org/x/sys from v0.2.0 to account for golang/go#49219. Signed-off-by: Sienna Lloyd <sienna@linux.com>
@mxplusb I tagged sys about 3 weeks ago, so I don't know what problem you're trying to solve but it's probably not this issue. sys will be tagged again in another couple weeks if that does turn out to be what you need. |
This picks up a new 2022 version of golang.org/x/sys and is needed to fix building using Go 1.18 on aarch64-darwin which is caused by golang/go#49219.
…nc to fix building error bump the two packages version to fix building error in go 1.18 (see: https://stackoverflow.com/a/71508032/10068476 and golang/go#49219)
…nc to fix building error bump the two packages version to fix building error in go 1.18 on darwin (see: https://stackoverflow.com/a/71508032/10068476 and golang/go#49219)
Needed to bump x/sys dependency due to golang/go#49219 to ensure Go 1.18 compatibility on darwin. This commit revendors our AzureStack fork to bring in: openshift/terraform-provider-azurestack#5 which updated x/sys with the following commands: go get -u golang.org/x/sys go mod tidy -compat=1.17 && go mod vendor
Needed to bump x/sys dependency due to golang/go#49219 to ensure Go 1.18 compatibility on darwin. This commit revendors our AzureStack fork to bring in: openshift/terraform-provider-azurestack#5 which updated x/sys with the following commands: go get -u golang.org/x/sys go mod tidy -compat=1.17 && go mod vendor
greplogs --dashboard -md -l -e '//go:linkname must refer to declared function or variable'
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-10_14
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-10_15
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-11_0
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-amd64-nocgo
2021-10-28T22:38:00-26ed8fd-af05d8b/darwin-arm64-11_0-toothrot
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-10_14
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-10_15
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-11_0
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-amd64-nocgo
2021-10-28T20:50:34-26ed8fd-d0751b1/darwin-arm64-11_0-toothrot
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-10_14
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-10_15
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-11_0
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-amd64-nocgo
2021-10-28T18:17:57-26ed8fd-f229e70/darwin-arm64-11_0-toothrot
2021-10-28T18:10:59-26ed8fd-ed475fe/darwin-amd64-10_14
2021-10-28T17:52:59-26ed8fd-3124968/darwin-amd64-11_0
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-10_14
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-10_15
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-11_0
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-amd64-nocgo
2021-10-28T16:54:58-26ed8fd-6bd0e7f/darwin-arm64-11_0-toothrot
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-10_14
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-11_0
2021-10-28T16:08:36-26ed8fd-6f0185b/darwin-amd64-nocgo
2021-10-28T15:55:26-26ed8fd-61536ec/darwin-amd64-11_0
2021-10-28T15:35:25-26ed8fd-278b9b3/darwin-amd64-11_0
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-10_14
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-10_15
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-amd64-11_0
2021-10-28T15:08:31-26ed8fd-5c98bcb/darwin-arm64-11_0-toothrot
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-10_14
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-10_15
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-11_0
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-amd64-nocgo
2021-10-28T14:25:03-26ed8fd-a3bb28e/darwin-arm64-11_0-toothrot
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-10_14
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-10_15
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-11_0
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-amd64-nocgo
2021-10-28T03:44:12-26ed8fd-2ff1074/darwin-arm64-11_0-toothrot
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-10_14
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-10_15
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-amd64-11_0
2021-10-28T03:35:34-26ed8fd-b8f928b/darwin-arm64-11_0-toothrot
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-10_14
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-10_15
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-11_0
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-amd64-nocgo
2021-10-28T02:35:22-26ed8fd-056dfe6/darwin-arm64-11_0-toothrot
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-10_14
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-10_15
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-11_0
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-amd64-nocgo
2021-10-28T01:15:26-26ed8fd-b2fe2eb/darwin-arm64-11_0-toothrot
The text was updated successfully, but these errors were encountered: