Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.imager: use xorg.* packages directly instead of xlibsWrappe… #204550

Merged
merged 1 commit into from
Dec 6, 2022
Merged

rPackages.imager: use xorg.* packages directly instead of xlibsWrappe… #204550

merged 1 commit into from
Dec 6, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Dec 4, 2022 •
edited
Loading

…r indirection

Validated as no change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
rPackages.imager: use xorg.* packages directly instead of xlibsWrappe…
c5b0d1e 
…r indirection

Validated as no change in `out` output with `diffoscope`.
@trofi trofi requested a review from jbedo as a code owner December 4, 2022 22:37
@trofi trofi mentioned this pull request Dec 4, 2022
Closed
83 tasks
@trofi trofi mentioned this pull request Dec 5, 2022
Merged
13 tasks
@jbedo jbedo merged commit 43f3963 into NixOS:master Dec 6, 2022
@trofi trofi deleted the rPackages.imager-without-xlibsWrapper branch December 6, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedo jbedo Awaiting requested review from jbedo jbedo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @jbedo