xlibsWrapper: remove deprecated and now unused wrapper package #207938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/call-for-help-to-migrate-packages-from-xlibswrapper/22203/2 |
trofi
force-pushed
the
xlibsWrapper-removal
branch
from
d64e34d
to
4485879
Compare
iblech
reviewed
Dec 27, 2022
trofi
force-pushed
the
xlibsWrapper-removal
branch
from
4485879
to
7fcb9dd
Compare
|
Forgot one last user: |
|
@ofborg eval |
There should be no reason to use this package as it's a remnant of
non-modular X. Chances are you do not want every single library it
used to pull in:
freetype fontconfig xorg.xorgproto xorg.libX11 xorg.libXt
xorg.libXft xorg.libXext xorg.libSM xorg.libICE
Just pick the ones you really need instead.
`nixpkgs` does not have any users of `xlibsWrapper`.
Closes: NixOS#194054
trofi
force-pushed
the
xlibsWrapper-removal
branch
from
7fcb9dd
to
3c478e4
Compare
|
Rebased past |
|
ofborg is merging the PR into master so this is not strictly necessary. |
|
Thank you so much trofi! ❤️ |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 9, 2023
Update shell.nix <!-- Please describe your changes on the following line: --> After NixOS/nixpkgs#207938 was merged the option `pkgs.xlibsWrapper` was removed. This PR replacing it with `xorg.libX11` as this is enouth to build and test in `nix-shell` environment. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] These changes do not require tests because PR updates nix build environment. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no reason to use this package as it's a remnant of non-modular X. Chances are you do not want every single library it used to pull in:
Just pick the ones you really need instead.
nixpkgsdoes not have any users ofxlibsWrapper.Closes: #194054
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes