Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo/hooks: make vendored deps writeable if dir #211249

Closed
wants to merge 1 commit into from
Closed

cargo/hooks: make vendored deps writeable if dir #211249

wants to merge 1 commit into from

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Jan 17, 2023

One case where this commonly appears is when using the cargoLock.lockfile argument to buildRustPackage. Without this fix, build scripts failed when they tried to write to the vendor dir.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bennofs
cargo/hooks: make vendored deps writeable if dir
85e64e1 
One case where this commonly appears is when using the `cargoLock.lockfile`
argument to `buildRustPackage`.  Without this fix, build scripts failed
when they tried to write to the vendor dir.
@zowoq zowoq mentioned this pull request Mar 8, 2023
Merged
12 tasks
@figsoda
Copy link
Member

figsoda commented Mar 8, 2023

I didn't see this PR and merged #218472 which is almost identical, sorry about that @bennofs

@figsoda figsoda closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennofs @figsoda