rustPlatform.cargoSetupHook: dereference symlinks in cargoDeps #218472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpackFile doesn't dereference symlinks if cargoDeps is a directory, and some cargo builds run into permission issues because the files the symlinks point to are not writable.
|
@ofborg build fd binserve wezterm sapling |
|
Looks like it was a dupe of #211249? |
|
It was, I didn't see that pr |
13 tasks
This was referenced Mar 29, 2023
benjaminedwardwebb
added a commit
to benjaminedwardwebb/nixpkgs
that referenced
this pull request
Mar 29, 2023
Fix the dmenu-rs package derivation, which was broken after changes to the rustPlatform nixpkgs tooling. The issue linked below was specifically raised on an early version of NixOS 23.05. This is through no fault of those changes. In fact, the brittle hack in the dmenu-rs derivation that broke can now be entirely removed because of the very changes that broke them. This commit also bumps dmenu-rs from 5.5.1 to 5.5.2. See upstream for details on the changes. See NixOS#222351 See NixOS#218472 See https://github.com/Shizcow/dmenu-rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpackFile doesn't dereference symlinks if cargoDeps is a directory, and some cargo builds run into permission issues because the files the symlinks point to are not writable.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)