Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpython: add loongarch triplets #229183

Merged
merged 1 commit into from
May 1, 2023

Conversation

jackyliu16
Copy link
Contributor

@jackyliu16 jackyliu16 commented Apr 30, 2023

Using patch ref on: python/cpython#90656
to add loongarch triplets for using cpython in loongarch

Note: This patch is being reviewed by cpython

Test build pkgsCross.python38/11.withPackages(ps: with ps; [requests]) successes. which need pip and pip is depend on cpython.

Description of changes
  1. add patch into cpython folder to add loongarch triplets.
  2. using patch if hostPlatform is loongarch
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

  using patch ref on: python/cpython#90656
  to add loongarch triplets for using cpython in loongarch

  Note: This patch is being reviewed by cpython
@jackyliu16 jackyliu16 requested a review from FRidh as a code owner April 30, 2023 21:30
@jackyliu16 jackyliu16 requested a review from wegank April 30, 2023 21:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 30, 2023
@wegank wegank merged commit 2ff0cf4 into NixOS:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants