Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new triplets for 64-bit LoongArch #90656

Closed
loongson-zn mannequin opened this issue Jan 24, 2022 · 5 comments · Fixed by #30939
Closed

Add new triplets for 64-bit LoongArch #90656

loongson-zn mannequin opened this issue Jan 24, 2022 · 5 comments · Fixed by #30939
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@loongson-zn
Copy link
Mannequin

loongson-zn mannequin commented Jan 24, 2022

BPO 46498
Nosy @loongson-zn, @xen0n
PRs
  • gh-90656: Add platform triplets for 64-bit LoongArch (LA64) #30939
  • Files
  • loongarch64.diff
  • loongarch64-new.diff: update loongarch64.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2022-01-24.05:00:22.024>
    labels = ['build', '3.9']
    title = 'Add new triplets for loongarch64'
    updated_at = <Date 2022-01-27.08:05:30.042>
    user = 'https://github.com/loongson-zn'

    bugs.python.org fields:

    activity = <Date 2022-01-27.08:05:30.042>
    actor = 'loongson-zn'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2022-01-24.05:00:22.024>
    creator = 'loongson-zn'
    dependencies = []
    files = ['50579', '50590']
    hgrepos = []
    issue_num = 46498
    keywords = ['patch']
    message_count = 2.0
    messages = ['411701', '411842']
    nosy_count = 2.0
    nosy_names = ['loongson-zn', 'xen0n']
    pr_nums = ['30939']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue46498'
    versions = ['Python 3.9']

    @loongson-zn loongson-zn mannequin added 3.9 only security fixes build The build process and cross-build labels Jan 24, 2022
    @xen0n
    Copy link
    Mannequin

    xen0n mannequin commented Jan 26, 2022

    First of all I think the changes should probably go in main branch first, then backported to the older branches if possible; although IMO you'd be much better off just backporting and carrying the patch yourselves.

    Secondly the suggested patch is not consistent with the LoongArch toolchain spec, in that it didn't use the multiarch identifiers in the spec document (https://github.com/loongson/LoongArch-Documentation/blob/a8a004148734445480659a5e25ef985817881341/docs/LoongArch-toolchain-conventions-EN.adoc, Table 12), but rather the old-world one; see the discussion at loongarch64#1 (in Chinese) too.

    @loongson-zn
    Copy link
    Mannequin Author

    loongson-zn mannequin commented Jan 27, 2022

    loongarch64.diff has been modified according to the new toolchain spec.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    jackyliu16 added a commit to jackyliu16/nixpkgs that referenced this issue Apr 30, 2023
      using patch ref on: python/cpython#90656
      to add loongarch triplets for using cpython in loongarch
    
      Note: This patch is being reviewed by cpython
    jackyliu16 added a commit to jackyliu16/nixpkgs that referenced this issue May 2, 2023
      using patch ref on: python/cpython#90656
      to add loongarch triplets for using cpython in loongarch
    
      Note: This patch is being reviewed by cpython
    @arhadthedev arhadthedev removed the 3.9 only security fixes label May 6, 2023
    @erlend-aasland erlend-aasland added the type-feature A feature request or enhancement label May 6, 2023
    @corona10
    Copy link
    Member

    corona10 commented May 8, 2023

    I left the opinion about the issue: #30939 (comment)

    @erlend-aasland erlend-aasland changed the title Add new triplets for loongarch64 Add new triplets for 64-bit LoongArch May 9, 2023
    @erlend-aasland
    Copy link
    Contributor

    Should we also add triplets for LA32R and LA32S?

    erlend-aasland pushed a commit that referenced this issue May 9, 2023
    Signed-off-by: Zhang Na <zhangna@loongson.cn>
    Co-authored-by: WANG Xuerui <git@xen0n.name>
    @erlend-aasland
    Copy link
    Contributor

    @xen0n, let me know if you want your attribution in the NEWS and What's New entries (IMO, it seems like that would be appropriate). We can easily patch those two files in a follow-up PR.

    carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
    * main:
      pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
      pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
      pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
      require-pr-label.yml: Add missing "permissions:" (python#104309)
      pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
      pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
    carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
    * main: (29 commits)
      pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
      pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
      pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
      require-pr-label.yml: Add missing "permissions:" (python#104309)
      pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
      pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
      pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
      pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
      pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
      pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
      pythonGH-104284: Fix documentation gettext build (python#104296)
      pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
      pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
      pythongh-99108: fix typo in Modules/Setup (python#104293)
      pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
      pythongh-103193: Improve `getattr_static` test coverage (python#104286)
      Trim trailing whitespace and test on CI (python#104275)
      pythongh-102500: Remove mention of bytes shorthand (python#104281)
      pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
      pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
      ...
    carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
    * main: (156 commits)
      pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304)
      pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441)
      pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096)
      pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217)
      pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312)
      pythongh-104240: return code unit metadata from codegen (python#104300)
      pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
      pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
      pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
      require-pr-label.yml: Add missing "permissions:" (python#104309)
      pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
      pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
      pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
      pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
      pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
      pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
      pythonGH-104284: Fix documentation gettext build (python#104296)
      pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
      pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
      pythongh-99108: fix typo in Modules/Setup (python#104293)
      ...
    carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
    * main: (35 commits)
      pythongh-97696 Add documentation for get_coro() behavior with eager tasks (python#104304)
      pythongh-97933: (PEP 709) inline list/dict/set comprehensions (python#101441)
      pythongh-99889: Fix directory traversal security flaw in uu.decode() (python#104096)
      pythongh-104184: fix building --with-pydebug --enable-pystats (python#104217)
      pythongh-104139: Add itms-services to uses_netloc urllib.parse. (python#104312)
      pythongh-104240: return code unit metadata from codegen (python#104300)
      pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
      pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
      pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
      require-pr-label.yml: Add missing "permissions:" (python#104309)
      pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
      pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
      pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
      pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
      pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
      pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
      pythonGH-104284: Fix documentation gettext build (python#104296)
      pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
      pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
      pythongh-99108: fix typo in Modules/Setup (python#104293)
      ...
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    3 participants