llvmPackages.lldb: deduplicate >10

[Artturin]

Once reviewed the commits will be squashed

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[sternenseemann]

Another more general point I am wondering about if the common expression shouldn't be a function that returns a package function. That way we could have a distinction between overrideable inputs (e.g. monorepoSrc and arguments that just customize the common expression (like patches), but are not an interface, really.

This could also save us extreme version comparison awkwardness. An example for this could be GHC's common-hadrian.nix or the SBCL common expression.

[sternenseemann]

(May be nice to use substituteAll for this in the future, but can be a different PR.)

[Artturin]

It'll cause a hash change

          (callPackage
            ({ substituteAll, libclang }: substituteAll
              {
                src = ./lldb/resource-dir.patch;
                clangLibDir = "${libclang.lib}/lib";
              })
            { })

[sternenseemann]

Yes, something for a future cleanup I'd say!

[Artturin]

#253533