Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages.lldb: use substituteAll #253533

Merged
merged 4 commits into from
Sep 6, 2023
Merged

llvmPackages.lldb: use substituteAll #253533

merged 4 commits into from
Sep 6, 2023

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 5, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Sep 5, 2023
Merged
12 tasks
@Artturin Artturin force-pushed the llvmusesuball branch 2 times, most recently from 48249a4 to 436748a Compare September 5, 2023 23:32
@Artturin Artturin marked this pull request as ready for review September 5, 2023 23:47
Artturin
Artturin commented Sep 6, 2023
View reviewed changes
pkgs/development/compilers/llvm/git/default.nix
{ };
in
[
./lldb/procfs.patch # FIXME: do we need this?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented for llvm 16, git still uses 15

@Artturin
Copy link
Member Author

Artturin commented Sep 6, 2023 •
edited
Loading

Everything builds

nixpkgs-review pr 253533 --package-regex llvmPackages -c commit

@Artturin Artturin mentioned this pull request Sep 6, 2023
Closed
@Artturin Artturin merged commit 872e54e into NixOS:staging Sep 6, 2023
19 of 22 checks passed
@Artturin Artturin deleted the llvmusesuball branch September 6, 2023 18:17
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

@rrbutani rrbutani Awaiting requested review from rrbutani

@dtzWill dtzWill Awaiting requested review from dtzWill

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@primeos primeos Awaiting requested review from primeos

@lovek323 lovek323 Awaiting requested review from lovek323

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artturin @rrbutani