raylib: Fix audio #243851
Merged
raylib: Fix audio #243851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
When upgrading from `4.2.0` to `4.5.0` in NixOS#243155 the audio fix was removed. This fix didn't apply properly any more, because the `cmake` build in `4.5.0` is producing shared objects with the wrong version in the name. The commit raysan5/raylib@0d4db7a which fixes the versioning issue does not appear to have made it into the `4.5.0` tag. Removing the audio fix did actually makes the project compile, however when running games built against `raylib`, no audio device was found.
basile-henry
force-pushed
the
raylib-fix-audio
branch
from
bb8f14e
to
6fc1dc0
Compare
drupol
approved these changes
Jul 20, 2023
|
Thanks! 😄 What are the next steps to get this merged? Wait for CI? And then someone with write access can merge it or is it automated? |
|
I'll wait for the ci to be done and merge afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading from
4.2.0to4.5.0in #243155 the audio fix wasremoved. This fix didn't apply properly any more, because the
cmakebuild in
4.5.0is producing shared objects with the wrong version inthe name.
The commit raysan5/raylib@0d4db7a
which fixes the versioning issue does not appear to have made it into
the
4.5.0tag.Removing the audio fix did actually makes the project compile, however
when running games built against
raylib, no audio device was found.Description of changes
cmakebuild4.2.0that is still relevantThings done
I have tested a few games in
raylib-gamesto make sure the audio works on my machine (NixOS 23.05)sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)