Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11-kit: use mesonEmulatorHook for cross compilation #245124

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jul 24, 2023

Description of changes

Follow up of #244633, forgot that I have binfmt_misc configured when testing that PR.

Things done
  • Built on platform(s)
    • x86_64-linux
    • riscv64-linux (cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 24, 2023
@Mindavi
Copy link
Contributor

Mindavi commented Jul 24, 2023

Meh, too bad we have to use an emulator, it prevents any non-emulator supported platform from working. But LGTM, and tested that x86 -> aarch64 compile is working.

@ghost
Copy link

ghost commented Aug 5, 2023

Meh, too bad we have to use an emulator, it prevents any non-emulator supported platform from working.

Yeah I agree; hopefully upstream fixes this.

There are extended instruction sets for some architectures that QEMU doesn't support, and p11-kit is nowhere near as important as access to those accelerators.

@NickCao
Copy link
Member Author

NickCao commented Aug 5, 2023

Yeah I agree; hopefully upstream fixes this.

Already done on master: p11-glue/p11-kit@3ba2c55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants