Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11-kit: mark broken if !stdenv.buildPlatform.canExecute stdenv.hostPlatform #246643

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2023

Description of changes

p11-kit does not cross-compile. This prevents the NixOS installer from cross-compiling. Therefore, we mark it broken in this case and omit it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

…latform

p11-kit does not cross-compile.  This prevents the NixOS installer
from cross-compiling.  Therefore, we mark it broken in this case and
omit it.
@ghost ghost marked this pull request as ready for review August 1, 2023 20:57
@ghost ghost self-requested a review as a code owner August 1, 2023 20:57
@ghost ghost mentioned this pull request Aug 1, 2023
12 tasks
@ius
Copy link
Contributor

ius commented Aug 1, 2023

These are in staging and should fix cross #244633 #245124

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 1, 2023
@yu-re-ka
Copy link
Contributor

yu-re-ka commented Aug 1, 2023

Also see #246360 #246602

@ghost
Copy link
Author

ghost commented Aug 2, 2023

git cherry-pick 3ca33e5ef4f8c3e24013905cf741330c9ace3a6c
git cherry-pick 64fe5a97f1938c3883273444f2e4252a3448a71e

@ghost ghost closed this Aug 2, 2023
@ghost
Copy link
Author

ghost commented Aug 5, 2023

Hrm, this is still broken in situations where we don't have an emulator for the hostPlatform. And p11-kit is an optional (not mandatory) dependency of its two primary downstream users (nss and gnutls). So I'd like to bring this back at some point in the form of broken = !emulatorAvailable.

FWIW, the case where no emulator is available, for me, is -march=octeon, which QEMU doesn't support. And the octeon extensions (unaligned loads, bit manipulation instructions, AES) are way way way more important to me than p11-kit is.

@ghost ghost deleted the pr/p11-kit/broken-if-cross branch January 23, 2024 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: systemd 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants