Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian-devscripts: update platforms to platforms.unix #245747

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jul 27, 2023

Description of changes

Updates the allowed platforms for the debian-devscripts package from platforms.linux to platforms.unix, driven by the desire to include *-darwin. I've tested this change on an M1 Mac and it builds and binaries run successfully.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 27, 2023
@ofborg ofborg bot requested a review from 7c6f434c July 27, 2023 14:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 27, 2023
@7c6f434c 7c6f434c merged commit 869d0f8 into NixOS:master Jul 27, 2023
@anoadragon453 anoadragon453 deleted the anoa/debian_debscripts_darwin branch July 27, 2023 18:42
anoadragon453 added a commit to matrix-org/synapse that referenced this pull request Jul 28, 2023
This commit updates the version of nixpkgs that is pinned in
`flake.lock` from `7a32a141db568abde9bc389845949dc2a454dfd3` to
`8cacc05fbfffeaab910e8c2c9e2a7c6b32ce881a`. The new revision
contains NixOS/nixpkgs#245747, which
allows `debian-devscripts` to be built on MacOS (darwin), which
our development environemnt requires for update the Debian
changelog during releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants