Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_21: 1.21rc4 -> 1.21.0 #248027

Merged
merged 1 commit into from
Aug 20, 2023
Merged

go_1_21: 1.21rc4 -> 1.21.0 #248027

merged 1 commit into from
Aug 20, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 8, 2023

Changelog: https://go.dev/doc/devel/release#go1.21

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested review from kalbasit and Mic92 as code owners August 8, 2023 21:36
@zowoq zowoq marked this pull request as draft August 8, 2023 21:41
@zowoq zowoq added the 2.status: work-in-progress This PR isn't done label Aug 8, 2023
@zowoq
Copy link
Contributor Author

zowoq commented Aug 8, 2023

I think I'll leave this open as a draft and merge it to master after #238100 goes through staging-next.

@ofborg ofborg bot requested a review from qbit August 8, 2023 22:58
@SuperSandro2000
Copy link
Member

You could also target staging-next with this PR, it does not really matter but and you don't need to worry about remembering to merge this.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 9, 2023

I want to leave this open for visibility as I don't want someone to open a PR adding go_1_21/buildGo121Module on master.

@zowoq zowoq mentioned this pull request Aug 12, 2023
Closed
12 tasks
mdwn
mdwn approved these changes Aug 17, 2023
View reviewed changes
Copy link

@mdwn mdwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is still in draft, but this LGTM.

@diamondburned
Copy link

I think I'll leave this open as a draft and merge it to master after #238100 goes through staging-next.

Why is this required? Isn't #238100 over 2 months old?

@zowoq
Copy link
Contributor Author

zowoq commented Aug 19, 2023

I think I'll leave this open as a draft and merge it to master after #238100 goes through staging-next.

Why is this required? Isn't #238100 over 2 months old?

It was only merged a couple of weeks ago.

https://nixpk.gs/pr-tracker.html?pr=238100

@zowoq zowoq mentioned this pull request Aug 20, 2023
Closed
12 tasks
@zowoq zowoq linked an issue Aug 20, 2023 that may be closed by this pull request
Package request: go_1_21 #250350
Closed
@zowoq zowoq removed the 2.status: work-in-progress This PR isn't done label Aug 20, 2023
@github-actions github-actions bot added 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 6.topic: policy discussion 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: TeX Issues regarding texlive and TeX in general labels Aug 20, 2023
@github-actions github-actions bot added 6.topic: lua 6.topic: lib The Nixpkgs function library labels Aug 20, 2023
@zowoq zowoq changed the base branch from staging to master August 20, 2023 21:51
@github-actions github-actions bot removed 6.topic: python 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 6.topic: policy discussion 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: lib The Nixpkgs function library labels Aug 20, 2023
@zowoq zowoq marked this pull request as ready for review August 20, 2023 21:52
@zowoq zowoq merged commit 8ed712e into NixOS:master Aug 20, 2023
@zowoq zowoq deleted the go121 branch August 20, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdwn mdwn mdwn approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@qbit qbit Awaiting requested review from qbit

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: go_1_21
4 participants
@zowoq @SuperSandro2000 @diamondburned @mdwn