Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_21: init at 1.21.0 #250345

Closed
wants to merge 1 commit into from
Closed

go_1_21: init at 1.21.0 #250345

wants to merge 1 commit into from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Aug 20, 2023 •
edited
Loading

Release-Notes: https://tip.golang.org/doc/go1.21
Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

Description of changes

Things done

Add go_1.21 & add buildGo121Module and test build.
Backport two patches that were not applying cleanly.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Closes: #250350

@mfrw
go_1_21: init at 1.21.0
0a8a8f3 
Backport two patches that were not applying cleanly.

Release-Notes: https://tip.golang.org/doc/go1.21
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 20, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 20, 2023
@ofborg ofborg bot requested review from Mic92, kalbasit, qbit and zowoq August 20, 2023 13:31
@zowoq
Copy link
Contributor

zowoq commented Aug 20, 2023

Duplicate of #238100 and #248027

@zowoq zowoq closed this Aug 20, 2023
zowoq
zowoq reviewed Aug 20, 2023
View reviewed changes
pkgs/top-level/all-packages.nix
go = go_1_20;
buildGoModule = buildGo120Module;
buildGoPackage = buildGo120Package;
go = go_1_21;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wait usual wait until 1.21.1 before bumping the default version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thanks.
I was not aware :)

@mfrw mfrw deleted the mfrw/go_1_21 branch September 19, 2023 04:20
@mfrw mfrw mentioned this pull request Feb 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@kalbasit kalbasit Awaiting requested review from kalbasit

@qbit qbit Awaiting requested review from qbit

Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: go_1_21
3 participants
@mfrw @zowoq @Janik-Haag