llvmPackages_{15,16,git}.clang.cc: Fix canExecute == true cross #250612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
mentioned this pull request
12 tasks
ofborg
bot
added
6.topic: cross-compilation
Artturin
changed the title
Artturin
changed the title
Fixes `pkgsCross.musl64.llvmPackages_16.clang.cc`.
buildLlvmTools shouldn't be needed at all when build canExecute host,
but i'll need more work to fix.
`build/build.ninja`
has lines like
```
build include/clang/AST/TypeNodes.inc | ${cmake_ninja_workdir}include/clang/AST/TypeNodes.inc: CUSTOM_COMMAND bin/clang-tblgen bin/clang-tblgen /build/clang-src-16.0.6/clang/include/clang/Basic/TypeNodes.td || bin/clang-tblgen lib/Support/obj.clangSupport
COMMAND = cd /build/clang-src-16.0.6/clang/build && clang-tblgen -gen-clang-type-nodes ...
```
`&& clang-tblgen` should be `&& bin/clang-tblgen`
Maybe `"-DCLANG_TABLEGEN=bin/clang-tblgen"` would work
Reported here:
#226551 (comment)
Co-authored-by: Artturin <Artturin@artturin.com>
|
Better fix in #251853 |
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reported here:
#226551 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)