Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_{15,16,git}.clang.cc: Fix canExecute == true cross #250612

Closed
wants to merge 2 commits into from
Closed

llvmPackages_{15,16,git}.clang.cc: Fix canExecute == true cross #250612

wants to merge 2 commits into from

Commits on Aug 21, 2023

  1. pkgs.test.cross.sanity: add musl64-llvm tests

    Adam Joseph committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0716e49 View commit details
    Browse the repository at this point in the history

  2. llvmPackages_{15,16,git}.clang.cc: Fix canExecute == true cross 

    Fixes `pkgsCross.musl64.llvmPackages_16.clang.cc`.

buildLlvmTools shouldn't be needed at all when build canExecute host,
but i'll need more work to fix.

`build/build.ninja`

has lines like

```
build include/clang/AST/TypeNodes.inc | ${cmake_ninja_workdir}include/clang/AST/TypeNodes.inc: CUSTOM_COMMAND bin/clang-tblgen bin/clang-tblgen /build/clang-src-16.0.6/clang/include/clang/Basic/TypeNodes.td || bin/clang-tblgen lib/Support/obj.clangSupport
  COMMAND = cd /build/clang-src-16.0.6/clang/build && clang-tblgen -gen-clang-type-nodes ...
```

`&& clang-tblgen` should be `&& bin/clang-tblgen`

Maybe `"-DCLANG_TABLEGEN=bin/clang-tblgen"` would work

Reported here:

  #226551 (comment)

Co-authored-by: Artturin <Artturin@artturin.com>
    @Artturin
    Adam Joseph and Artturin committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    45ee21c View commit details
    Browse the repository at this point in the history