mise: 2023.12.35 -> 2024.1.11 rebrand from rtx #279158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently tests fail. Unrelated to the name change I think: test cli::render_mangen::tests::test_render_mangen ... ok
test cli::run::tests::test_task_run ... error: test failed, to rerun pass `--bin mise`
Caused by:
process didn't exit successfully: `/build/source/target/x86_64-unknown-linux-gnu/release/deps/mise-655ead5b1d3f3fff --test-threads=1 '--skip=cli::plugins::ls::tests::test_plugin_list_urls'` (exit status: 1)I'll try to figure this out Edit: it seems it works on darwin, huh... Edit2: Fixed. One new path in patchShebangs was missing. |
ofborg
bot
added
8.has: clean-up
8.has: package (new)
konradmalik
requested review from
AndersonTorres,
SuperSandro2000,
sefidel and
wegank
konradmalik
changed the title
konradmalik
force-pushed
the
rtx
branch
2 times, most recently
from
bf44301
to
3fccc56
Compare
konradmalik
changed the title
SuperSandro2000
approved these changes
Jan 9, 2024
rebrand info: https://mise.jdx.dev/rtx.html added one new patchShebangs path for test_task_run
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3269 |
Reviewed pointsResult of 1 package built:
|
onemoresuza
approved these changes
Jan 14, 2024
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
rtxwas rebranded upstream tomise. See: https://mise.jdx.dev/rtx.html.This PR renames the package, creates an alias and updates it to 2024.1.11
Needed to add one new patchShebangs path for
test_task_run(./test/cwd/.mise/tasks/filetask). Without it, this test failed in checkPhase.Closes #278977
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.