Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: rtx has been renamed to mise #4909

Closed
2 tasks done
AntonFriberg opened this issue Jan 16, 2024 · 1 comment · Fixed by #4910
Closed
2 tasks done

bug: rtx has been renamed to mise #4909

AntonFriberg opened this issue Jan 16, 2024 · 1 comment · Fixed by #4910
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@AntonFriberg
Copy link

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

rtx has been renamed to mise to avoid confusion with Nvidia's brand of graphics cards. See https://mise.jdx.dev/rtx.html for more info. Further, https://github.com/jdx/rtx now points to https://github.com/jdx/mise

nixpkgs have merged a fix NixOS/nixpkgs#279158

Not sure how to handle a breaking change like this but programs.rtx needs some changes due to this
https://github.com/nix-community/home-manager/blob/37d6eeceee464adc03585404eebd68765b3c8615/modules/programs/rtx.nix

I think simply changing the links and configuration file paths should be enough but the question is how to notify users of the breaking change so that they change their project specific config files. Probably enough to reference rtx official documentation.

Maintainer CC

@pedorich-n

System information

- system: `"x86_64-linux"`
 - host os: `Linux 5.10.0-27-amd64, Debian GNU/Linux, 11 (bullseye), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixpkgs"`
 - channels(afriberg): `"home-manager"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
@AntonFriberg AntonFriberg added bug triage Issues or feature request that have not been triaged yet labels Jan 16, 2024
@pedorich-n
Copy link
Contributor

Thanks for the issue!
I saw the program being renamed but missed a moment when the change got merged into nixpkgs.
I searched for similar cases in home-manager, but the only PR I found is this: #3265. They just moved programs to services.

So, I think I can just rename the program. I will add a news entry about breaking change as well.

pedorich-n added a commit to pedorich-n/home-manager that referenced this issue Jan 16, 2024
@pedorich-n pedorich-n mentioned this issue Jan 16, 2024
6 tasks
pedorich-n added a commit to pedorich-n/home-manager that referenced this issue Jan 17, 2024
pedorich-n added a commit to pedorich-n/home-manager that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants