sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 #283813

xyven1 · 2024-01-25T18:56:20Z

Gives access to many new configuration options, bug fixes, accessibility improvements, and features.
Changelog: ahrm/sioyek@main...development

Description of changes

Updated package version, rev, and sha256.
Added qtspeech dependency
Removed patch as Linux compile failure: ‘pdf_parse_link_uri’ was not declared in this scope ahrm/sioyek#804 was resolved
libsForQt5.callPackage -> qt6.callPackage
Added xyven1 to package maintainers.

Things done

Add a 👍 reaction to pull requests you find important.

stephen-huan

Opened a few PDFs and seems to work.

Result of nixpkgs-review pr 283813 run on x86_64-linux 1

1 package built:

sioyek

pca006132 · 2024-04-05T06:29:41Z

We can add qtwayland as well, see ahrm/sioyek#867

xyven1 · 2024-04-07T21:50:12Z

@pca006132 Do you have a good idea of how to do that? I am happy to add it, but I think first priority is to get this update merged, as Sioyek is more than a year of features behind in nixpkgs.

xyven1 · 2024-04-07T21:50:32Z

@podocarp Bumping this PR.

pca006132 · 2024-04-08T10:15:53Z

I think you can just add qtwayland to buildInputs and it will work.

pca006132 · 2024-04-08T17:54:04Z

But it seems that visual mark does not work well under Wayland for some reason. Perhaps we should not add qtwayland for now.

xyven1 · 2024-05-13T16:30:03Z

Been daily driving this for a while, no problems. Still haven't tested on MacOS. I'm on wayland for what its worth.

pkgs/applications/misc/sioyek/default.nix

stephen-huan

Still works for me.

Result of nixpkgs-review pr 283813 run on x86_64-linux 1

1 package built:

sioyek

pkgs/applications/misc/sioyek/default.nix

kilesduli · 2024-09-28T03:01:01Z

Hi, I noticed that the current version of sioyek in nixpkgs has an issue due to the newer version of mupdf. When reading larger PDFs and using t to jump between sections, there's a memory leak and a white screen. The latest commits in both the development and main branches don’t have this problem, so I’m hoping the PR can be merged to fix this.

stephen-huan · 2024-09-29T07:22:50Z

Perhaps one of us can post on the NixOS discourse in one of the PRs ready for review threads?

I agree that it's been too long for a straightforward update.

xyven1 · 2024-09-30T13:59:04Z

I will fix the merge conflicts today, so that this is PR is still viable. Again, I could update to an even more recent commit, but I (personally) noticed some regressions with the latest version, and feel that the version in this PR has most of the relevant changes (I'm open to any comments, and happy to bump the version if there is something important that got added or fixed).

In regards to adding to review threads, I have added this PR to the review threads in the discord multiple times, but never NixOS discourse, so that is another good option, if someone wants to do that.

stephen-huan · 2024-09-30T14:25:26Z

I will fix the merge conflicts today, so that this is PR is still viable. Again, I could update to an even more recent commit, but I (personally) noticed some regressions with the latest version, and feel that the version in this PR has most of the relevant changes (I'm open to any comments, and happy to bump the version if there is something important that got added or fixed).

Just out of curiosity, what have you noticed? I'm on ae733e9 which (was) latest on development branch, and before that, a3aeca4. To be clear, I'm not suggesting to bump the version, as I also haven't really noticed any improvements.

In regards to adding to review threads, I have added this PR to the review threads in the discord multiple times, but never NixOS discourse, so that is another good option, if someone wants to do that.

I can do this after the merge conflict is resolved.

xyven1 · 2024-09-30T14:31:01Z

Just out of curiosity, what have you noticed?

I'm not sure which version I was on (it was the developement branch version sometime this past month), but there was a noticeable performance regression on scrolling (the document would not be loaded after scrolling, and would take time to load after being brought into view, which significantly disrupted the reading experience for me). My guess is that this was an intentional memory saving or efficiency change which was either being tested, or needed some polish. YMMV

I can do this after the merge conflict is resolved.

Appreciated.

stephen-huan · 2024-09-30T14:34:25Z

The latest commits in both the development and main branches don’t have this problem, so I’m hoping the PR can be merged to fix this.

@kilesduli I just noticed you mentioned the latest commits in development and main fix your issue; have you tested that this PR actually fixes your issue? It's pinned to 36cff8d on development which is relatively old.

kilesduli · 2024-09-30T14:48:17Z

The latest commits in both the development and main branches don’t have this problem, so I’m hoping the PR can be merged to fix this.

@kilesduli I just noticed you mentioned the latest commits in development and main fix your issue; have you tested that this PR actually fixes your issue? It's pinned to 36cff8d on development which is relatively old.

@stephen-huan I just tested 36cff8, and it resolved my issue. However, I found new problem. When scrolling through the table of contents by press , the scrolling is not smooth and frames will drop. Additionally, after clicking on a section to jump to it, the screen freezes, and I have to scroll with the mouse wheel to unfreeze.

For me I would prefer to update.

xyven1 · 2024-09-30T16:13:23Z

Can i move it to pkgs/by-name since it is uses qt6.callPackage? Also I will check ae733e9

xyven1 · 2024-09-30T16:43:17Z

Seems as though the latest commit in the dev branch works ok for me (still seems a little worse? but very hard to quantify). I will bump it to that version

stephen-huan · 2024-09-30T17:18:06Z

Can i move it to pkgs/by-name since it is uses qt6.callPackage?

I think so, you take qt6 as an argument and refer to the qt libraries by qt6.qtbase, for instance. See this package.

Seems as though the latest commit in the dev branch works ok for me (still seems a little worse? but very hard to quantify). I will bump it to that version

Thanks for your sacrifice : )

xyven1 · 2024-09-30T18:03:36Z

Got it, I'll give that a shot

xyven1 · 2024-09-30T18:10:15Z

Seems to work. Moved to by-name

xyven1 · 2024-09-30T19:14:55Z

@kilesduli @stephen-huan Can you please run this PR, and see if everything is working as you would expect? If so, I will attempt to invoke merge-bot/

stephen-huan

Built and opened a few PDFs, looks good to me.

stephen-huan · 2024-09-30T21:48:08Z

pkgs/by-name/si/sioyek/package.nix

+    maintainers = with maintainers; [
+      podocarp
+      xyven1
+    ];


Feel free to add me as maintainer (lib.maintainers.stephen-huan).

kilesduli · 2024-10-01T05:06:27Z

@kilesduli @stephen-huan Can you please run this PR, and see if everything is working as you would expect? If so, I will attempt to invoke merge-bot/请你运行这个 PR，看看一切是否按预期工作？如果是的话，我将尝试调用 merge-bot

Looks good to me. Works fine.

stephen-huan · 2024-10-05T23:22:26Z

@xyven1 it seems you might need to add passthru.updateScript and nix-update-script as an input? See, e.g.

nixpkgs/pkgs/by-name/me/merge-ut-dictionaries/package.nix

Lines 1 to 5 in bc947f5

    
           { 
        
             lib, 
        
             fetchFromGitHub, 
        
             stdenvNoCC, 
        
             nix-update-script,

nixpkgs/pkgs/by-name/me/merge-ut-dictionaries/package.nix

Lines 73 to 78 in bc947f5

    
           passthru.updateScript = nix-update-script { 
        
             extraArgs = [ 
        
               "--version" 
        
               "branch" 
        
             ]; 
        
           };

and the contributing README. This seems to correctly generate PRs like #343670.

Reading the nix-update README I think the code for sioyek should be should be

passthru.updateScript = nix-update-script {
  extraArgs = [
    "--version"
    "branch=development"
  ];
};

If you could add this and also me as a maintainer, I'll post on the discourse, thanks!

xyven1 · 2024-10-05T23:50:32Z

Will do.

nixos-discourse · 2024-10-06T02:33:10Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2016

stephen-huan

Posted to PRs already reviewed, fingers crossed. Seemed to have a higher merged percentage than PRs ready for review.

xyven1 · 2024-10-06T03:37:16Z

@stephen-huan I very much appreciate the research you did on this to get the PR all shaped up for another merge attempt. When I created the PR I really thought it was just a basic version bump, but I guess because it is to a dev branch it is a little more suspect... Anyways hopefully this finally gets merged.

phanirithvij

tested locally nix run github:nixos/nixpkgs/refs/pull/283813/merge#sioyek

pkgs/by-name/si/sioyek/package.nix

Gives access to many new configuration options, bug fixes, accessibility improvements, and features.

ofborg bot requested a review from podocarp January 25, 2024 19:18

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 25, 2024

xyven1 force-pushed the sioyek-unstable branch from 61193b1 to 2781e4c Compare March 4, 2024 00:41

xyven1 changed the title ~~sioyek: 2.0.0 -> unstable-2024-01-25~~ sioyek: 2.0.0 -> 2.0.0-unstable-2024-01-25 Mar 4, 2024

stephen-huan approved these changes Apr 1, 2024

View reviewed changes

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 2, 2024

xyven1 requested a review from stephen-huan May 13, 2024 16:25

pluiedev suggested changes May 13, 2024

View reviewed changes

pkgs/applications/misc/sioyek/default.nix Outdated Show resolved Hide resolved

stephen-huan approved these changes May 13, 2024

View reviewed changes

pkgs/applications/misc/sioyek/default.nix Outdated Show resolved Hide resolved

xyven1 force-pushed the sioyek-unstable branch from 2781e4c to f62e23e Compare May 14, 2024 02:08

xyven1 requested a review from pluiedev May 14, 2024 02:12

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 22, 2024

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024

xyven1 force-pushed the sioyek-unstable branch from 21a8e5b to af420b2 Compare September 30, 2024 16:43

xyven1 changed the title ~~sioyek: 2.0.0 -> 2.0.0-unstable-2024-01-25~~ sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 Sep 30, 2024

xyven1 force-pushed the sioyek-unstable branch from af420b2 to d560639 Compare September 30, 2024 18:10

xyven1 force-pushed the sioyek-unstable branch from d560639 to abbf71b Compare September 30, 2024 18:49

xyven1 requested a review from stephen-huan September 30, 2024 19:12

stephen-huan approved these changes Sep 30, 2024

View reviewed changes

xyven1 force-pushed the sioyek-unstable branch from abbf71b to ead0d42 Compare October 6, 2024 01:36

ofborg bot requested a review from stephen-huan October 6, 2024 02:11

stephen-huan approved these changes Oct 6, 2024

View reviewed changes

phanirithvij approved these changes Oct 6, 2024

View reviewed changes

phanirithvij added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Oct 6, 2024

kilesduli approved these changes Oct 6, 2024

View reviewed changes

SuperSandro2000 reviewed Oct 6, 2024

View reviewed changes

pkgs/by-name/si/sioyek/package.nix Outdated Show resolved Hide resolved

sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29

9ed5dad

Gives access to many new configuration options, bug fixes, accessibility improvements, and features.

xyven1 force-pushed the sioyek-unstable branch from ead0d42 to 9ed5dad Compare October 6, 2024 15:58

ofborg bot requested a review from stephen-huan October 6, 2024 16:33

h7x4 merged commit 199d79e into NixOS:master Oct 7, 2024
26 checks passed

b-fein mentioned this pull request Oct 12, 2024

sioyek: fix typo in darwin build steps #348045

Open

13 tasks

stephen-huan mentioned this pull request Oct 15, 2024

sioyek fails to launch #348694

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 #283813

sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 #283813

xyven1 commented Jan 25, 2024 •

edited

Loading

stephen-huan left a comment

pca006132 commented Apr 5, 2024

xyven1 commented Apr 7, 2024

xyven1 commented Apr 7, 2024

pca006132 commented Apr 8, 2024

pca006132 commented Apr 8, 2024

xyven1 commented May 13, 2024

stephen-huan left a comment

kilesduli commented Sep 28, 2024

stephen-huan commented Sep 29, 2024 •

edited

Loading

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

kilesduli commented Sep 30, 2024

xyven1 commented Sep 30, 2024 •

edited

Loading

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

xyven1 commented Sep 30, 2024

xyven1 commented Sep 30, 2024

xyven1 commented Sep 30, 2024

stephen-huan left a comment

stephen-huan Sep 30, 2024

kilesduli commented Oct 1, 2024

stephen-huan commented Oct 5, 2024 •

edited

Loading

xyven1 commented Oct 5, 2024

nixos-discourse commented Oct 6, 2024

stephen-huan left a comment •

edited

Loading

xyven1 commented Oct 6, 2024

phanirithvij left a comment •

edited

Loading

sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 #283813

sioyek: 2.0.0 -> 2.0.0-unstable-2024-09-29 #283813

Conversation

xyven1 commented Jan 25, 2024 • edited Loading

Description of changes

Things done

stephen-huan left a comment

Choose a reason for hiding this comment

pca006132 commented Apr 5, 2024

xyven1 commented Apr 7, 2024

xyven1 commented Apr 7, 2024

pca006132 commented Apr 8, 2024

pca006132 commented Apr 8, 2024

xyven1 commented May 13, 2024

stephen-huan left a comment

Choose a reason for hiding this comment

kilesduli commented Sep 28, 2024

stephen-huan commented Sep 29, 2024 • edited Loading

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

kilesduli commented Sep 30, 2024

xyven1 commented Sep 30, 2024 • edited Loading

xyven1 commented Sep 30, 2024

stephen-huan commented Sep 30, 2024

xyven1 commented Sep 30, 2024

xyven1 commented Sep 30, 2024

xyven1 commented Sep 30, 2024

stephen-huan left a comment

Choose a reason for hiding this comment

stephen-huan Sep 30, 2024

Choose a reason for hiding this comment

kilesduli commented Oct 1, 2024

stephen-huan commented Oct 5, 2024 • edited Loading

xyven1 commented Oct 5, 2024

nixos-discourse commented Oct 6, 2024

stephen-huan left a comment • edited Loading

Choose a reason for hiding this comment

xyven1 commented Oct 6, 2024

phanirithvij left a comment • edited Loading

Choose a reason for hiding this comment

xyven1 commented Jan 25, 2024 •

edited

Loading

stephen-huan commented Sep 29, 2024 •

edited

Loading

xyven1 commented Sep 30, 2024 •

edited

Loading

stephen-huan commented Oct 5, 2024 •

edited

Loading

stephen-huan left a comment •

edited

Loading

phanirithvij left a comment •

edited

Loading