Linux compile failure: ‘pdf_parse_link_uri’ was not declared in this scope

[parkerlreed]

Arch Linux
gcc 13.2.1-3
libmupdf 1.23.0-1

      |                                  ^~~~~~~~
In file included from /usr/include/c++/13.2.1/bits/stl_iterator_base_funcs.h:66,
                 from /usr/include/c++/13.2.1/string:47,
                 from /usr/include/c++/13.2.1/bits/locale_classes.h:40,
                 from /usr/include/c++/13.2.1/bits/ios_base.h:41,
                 from /usr/include/c++/13.2.1/ios:44,
                 from /usr/include/c++/13.2.1/ostream:40,
                 from /usr/include/c++/13.2.1/iostream:41,
                 from pdf_viewer/pdf_view_opengl_widget.h:3:
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
In file included from pdf_viewer/utf8.h:32:
pdf_viewer/utf8/unchecked.h:179:40: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  179 |           class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                        ^~~~~~~~
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
pdf_viewer/utils.cpp: In function ‘ParsedUri parse_uri(fz_context*, std::string)’:
pdf_viewer/utils.cpp:120:29: error: ‘pdf_parse_link_uri’ was not declared in this scope; did you mean ‘pdf_parse_ind_obj’?
  120 |         fz_link_dest dest = pdf_parse_link_uri(mupdf_context, uri.c_str());
      |                             ^~~~~~~~~~~~~~~~~~
      |                             pdf_parse_ind_obj
pdf_viewer/utils.cpp: In function ‘void install_app(const char*)’:
pdf_viewer/utils.cpp:174:30: warning: unused parameter ‘argv0’ [-Wunused-parameter]
  174 | void install_app(const char *argv0)
      |                  ~~~~~~~~~~~~^~~~~
In file included from pdf_viewer/utf8.h:31,
                 from pdf_viewer/utils.h:21,
                 from pdf_viewer/ui.h:41,
                 from pdf_viewer/ui.cpp:1:
pdf_viewer/utf8/checked.h:268:34: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  268 |     class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                  ^~~~~~~~
In file included from /usr/include/c++/13.2.1/bits/stl_iterator_base_funcs.h:66,
                 from /usr/include/c++/13.2.1/string:47,
                 from pdf_viewer/ui.h:2:
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
In file included from pdf_viewer/utf8.h:32:
pdf_viewer/utf8/unchecked.h:179:40: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations]
  179 |           class iterator : public std::iterator <std::bidirectional_iterator_tag, uint32_t> {
      |                                        ^~~~~~~~
/usr/include/c++/13.2.1/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator

[marsam]

FWIW Alpine Linux has a patch to fix the build with mupdf-0.23.0 https://git.alpinelinux.org/aports/tree/community/sioyek/mupdf-0.23.0.patch?id=86e913eccf19b97a16f25d9b6cdf0f50232f1226

[xyven1]

Is there a patch for a more recent commit?

[ahrm]

This is fixed in the development branch here: https://github.com/ahrm/sioyek/tree/development.

[tennysontbardwell]

Patch for the current main (revision 277aed7). Version with --version changed: patch.

Disclaimer: I ran into other issues with my config files having unrecognized commands in this patch. That might be due to breaking changes in main, or an issue in my updated patch.