Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speechd: introduce minimal variant, use it everywhere, inject big variant impurely #329658

Merged
merged 5 commits into from
Jul 26, 2024
Merged

speechd: introduce minimal variant, use it everywhere, inject big variant impurely #329658

merged 5 commits into from
Jul 26, 2024

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jul 24, 2024 •
edited
Loading

Description of changes

TODO: figure out how to default this to false without breaking people.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vcunat vcunat mentioned this pull request Jul 25, 2024
Closed
13 tasks
@K900 K900 changed the base branch from master to staging-next July 26, 2024 13:07
@K900 K900 changed the title speechd: introduce minimal variant, use it everywhere speechd: introduce minimal variant, use it everywhere, inject big variant impurely Jul 26, 2024
mweinelt and others added 2 commits July 26, 2024 16:11
@mweinelt @K900
mbrola-voices: extract from mbrola, allow language selection
0a44760 
Allow filtering voices based on any number of extglob patterns.
@K900 @mweinelt
nixos/installer: ship only one mbrola voice per language
fd66223 
This reduces the size of mbrola-voices by 387M (647M -> 260M) for all
installers that ship with speechd, to make sure that they fit the output
limits of hydra while not compromising too much on accessbility.

Co-authored-by: Martin Weinelt <hexa@darmstadt.ccc.de>
@K900 K900 requested a review from davidak July 26, 2024 13:14
@K900 K900 marked this pull request as ready for review July 26, 2024 13:14
mweinelt
mweinelt approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i think that looks worth a try.

@vcunat vcunat merged commit b8688ce into NixOS:staging-next Jul 26, 2024
7 of 9 checks passed
@vcunat vcunat mentioned this pull request Jul 27, 2024
Merged
5 tasks
SuperSandro2000 pushed a commit to SuperSandro2000/nixpkgs that referenced this pull request Jul 27, 2024
@vcunat @SuperSandro2000
nixos/speechd: avoid by default on headless systems
2578ffa 
Incidentally this also fixes tests like nixosTests.installer.simple
/cc PR NixOS#329658
vcunat added a commit to vcunat/nixpkgs that referenced this pull request Jul 28, 2024
@vcunat
nixos/speechd: avoid by default on headless systems
1e9b3c1 
Incidentally this also fixes tests like nixosTests.installer.simple
/cc PR NixOS#329658
@vcunat
Copy link
Member

vcunat commented Jul 28, 2024 •
edited
Loading

Now that I think of it, I'm not sure if services.speechd is the best place, maybe programs.speechd?

I don't care really. But now when it's new (not even on master yet) such changes are easiest. So I'm just posting this note...

@K900
Copy link
Contributor Author

K900 commented Jul 28, 2024

It is conceptually a service, it's just started weird currently. The upcoming next release will be a proper systemd socket activated thing.

@vcunat
Copy link
Member

vcunat commented Jul 28, 2024 •
edited
Loading

Oh, OK. BTW, another way of saving space would be to default to English only (and perhaps just a single voice) unless you override your i18n.supportedLocales or something. That looks like ~7 MB only.

@DontEatOreo DontEatOreo mentioned this pull request Oct 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@davidak davidak Awaiting requested review from davidak

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@emilylange emilylange Awaiting requested review from emilylange

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (new) 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K900 @vcunat @mweinelt @h7x4