[Backport release-24.05] discord: format, update discord-canary and discord-ptb, refactor meta #348303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built:
|
Artturin
reviewed
Oct 13, 2024
pkgs/applications/networking/instant-messengers/discord/linux.nix
Outdated
Show resolved
Hide resolved
|
From what I see this is the issue: I think it's because #329658 didn't get backported? Commit adding speechd-minimal: 8e7a098 |
|
Yeah we don't want to backport, change the attr names in this backport |
Discord changed their download URLs and the new code is now more lenient regarding the actual download URL, as all we care about is the version in the URL path. Example: https://ptb.dl2.discordapp.net/apps/linux/0.0.110/discord-ptb-0.0.110.tar.gz ^-----^ This is what we need Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit 19afd56)
(cherry picked from commit 84e88c5)
DontEatOreo
force-pushed
the
backport-347313-to-release-24.05
branch
from
c58bd6c
to
2bc67ad
Compare
|
Backported 19afd56 just before my changes. It seems like it was forgotten to be backported in the last PR |
ofborg
bot
requested review from
jopejoe1,
Infinidoge,
Artturin and
Scrumplex
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
#347313
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.