Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weblate: 5.6.2 -> 5.7 #334849

Merged
merged 4 commits into from
Aug 19, 2024
Merged

weblate: 5.6.2 -> 5.7 #334849

merged 4 commits into from
Aug 19, 2024

Conversation

erictapen
Copy link
Member

Description of changes

First update to the new Weblate package and module. Builds and deploys on my test instance.

Changelogs:

New packages:

  • python3Packages.cyrtranslit
  • python3Packages.django-otp-webauthn

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erictapen erictapen marked this pull request as draft August 15, 2024 12:41
@mweinelt
Copy link
Member

Builds and deploys on my test instance.

CSS is 404.

@erictapen
Copy link
Member Author

Yeah that's why I switched back into draft mode. I'm investigating.

@erictapen
weblate: 5.6.2 -> 5.7
ca18f1c 
Changelog: https://github.com/WeblateOrg/weblate/releases/tag/weblate-5.7

Also had to rework django-compressor settings and aligned them more
closely with the official docs:
https://cheat.readthedocs.io/en/latest/django/compressor.html
@erictapen
Copy link
Member Author

Now it should work, had to rework the django-compressor settings.

@erictapen erictapen marked this pull request as ready for review August 15, 2024 14:19
@erictapen
Copy link
Member Author

@GrahamcOfBorg test weblate

@erictapen
Copy link
Member Author

I noticed that this also unbreaks the current weblate build, as it currently fails due to dependency version bounds.

Radvendii
Radvendii approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@Radvendii Radvendii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't vouch for the weblate details, but the nix side of things LGTM

@fricklerhandwerk fricklerhandwerk merged commit f5bb4b8 into NixOS:master Aug 19, 2024
29 of 31 checks passed
@erictapen erictapen mentioned this pull request Aug 29, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@Radvendii Radvendii Radvendii approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@wegank wegank Awaiting requested review from wegank

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erictapen @mweinelt @Radvendii @dotlambda @fricklerhandwerk