Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weblate: address additional review on package and dependencies #338217

Merged
merged 12 commits into from
Sep 4, 2024

Conversation

erictapen
Copy link
Member

Description of changes

Addresses @dotlambda s reviews in #325541 (comment) and #334849 (review).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't remove borgbackup from dependencies.

pkgs/development/python-modules/aeidon/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aeidon/default.nix Outdated Show resolved Hide resolved
@erictapen
Copy link
Member Author

You didn't remove borgbackup from dependencies.

See #325541 (comment)

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erictapen Thanks for following up on the review notes

Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of meta changes :)

@erictapen
Copy link
Member Author

erictapen commented Sep 2, 2024

I went through and double-checked all the licenses introduced by #325541 and #334849:

  • weblate
  • aeidon
  • ahocorasick-rs
  • celery
  • django-crispy-bootstrap3
  • phply
  • pyicumessageformat
  • siphashc
  • translate-toolkit
  • translation-finder
  • weblate-language-data
  • weblate-schemas
  • cyrtranslit
  • django-otp-webauthn

I actually had to fix the license for siphashc and extend the one for weblate itself, as some Python files use MIT.

Weblate vendors in a few dependencies with licenses such as Apache-2.0 and BSD-3-Clause, do we mention vendored dependencies in licenses?

As laid out in #338217 (comment), I'd leave CC0 licenses in files like SECURITY.md or CI configuration off for now. Or what do you think?

Will squash commits later when approved.

@fricklerhandwerk fricklerhandwerk merged commit d423e1e into NixOS:master Sep 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants