-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.03] golang backports #90217
Merged
Merged
[20.03] golang backports #90217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler does not need it anymore, has not needed it for many years iirc. This just goes in and pollutes the environment overriding the users GOPATH and causing grief. Go even warns about it itself, without vs with this commit: ```sh ~> go env GOPATH /home/manny/go ~> nix-shell -p go ~> go env GOPATH warning: GOPATH set to GOROOT (/nix/store/gvw1mfpdrk7i82884yhxf9lf5j3c12zm-go-1.14.1/share/go) has no effect /nix/store/gvw1mfpdrk7i82884yhxf9lf5j3c12zm-go-1.14.1/share/go ~> exit ~> nix-shell -I nixpkgs=cloned/NixOS/nixpkgs -p go ~> go env GOPATH /home/manny/go ~> exit ``` (cherry picked from commit a1e13f6)
(cherry picked from commit 416caeb)
https://golang.org/doc/devel/release.html#go1.14.minor (cherry picked from commit 8d41f9f)
(cherry picked from commit d1e7b00)
https://golang.org/doc/devel/release.html#go1.13.minor (cherry picked from commit 7da08af)
https://golang.org/doc/devel/release.html#go1.14.minor (cherry picked from commit 9f97814)
(cherry picked from commit aae680c)
The builder does not technically need the modSha256 of the vendor dir, and even though we pass it the entire vendor dir it makes sense not to risk having an accidental dependency on that variable. However, tools like [nixpkgs-update](https://github.com/ryantm/nixpkgs-update) need to inspect the `modSha256` of a package in order to be able to update them, and since this is a real part of the package (describes info about its dependencies) let's add it to `passthru`. Specifically, this allows us to run a cmd like `nix eval -f . tflint.modSha256` to get the current value, which is how the bot finds it to replace with the new version in the Rust ecosystem. (cherry picked from commit 5f77ff6)
This is done in response to complaints that the module format is not human readable. The vendor source blob is flat files and should be extremely readable. (cherry picked from commit 9761128)
(removed warning for 20.03) (cherry picked from commit a0ddea1)
@ofborg build go_1_13 |
Mic92
approved these changes
Jun 19, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we backport thebuildGoModule
changes (without the warning) so that we can usevendorSha256
on 20.03?Updated to include
buildGoModule
vendorSha256
.The last twogo
(1.14.4 and test fix) commits are instagingstaging-next, are they okay to backport or do they need to land in master first?