-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.03] golang backports #90217
Merged
Merged
[20.03] golang backports #90217
Commits on Jun 18, 2020
-
The compiler does not need it anymore, has not needed it for many years iirc. This just goes in and pollutes the environment overriding the users GOPATH and causing grief. Go even warns about it itself, without vs with this commit: ```sh ~> go env GOPATH /home/manny/go ~> nix-shell -p go ~> go env GOPATH warning: GOPATH set to GOROOT (/nix/store/gvw1mfpdrk7i82884yhxf9lf5j3c12zm-go-1.14.1/share/go) has no effect /nix/store/gvw1mfpdrk7i82884yhxf9lf5j3c12zm-go-1.14.1/share/go ~> exit ~> nix-shell -I nixpkgs=cloned/NixOS/nixpkgs -p go ~> go env GOPATH /home/manny/go ~> exit ``` (cherry picked from commit a1e13f6)
Configuration menu - View commit details
-
Copy full SHA for 6cd67ec - Browse repository at this point
Copy the full SHA 6cd67ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 296e584 - Browse repository at this point
Copy the full SHA 296e584View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9965e2 - Browse repository at this point
Copy the full SHA c9965e2View commit details -
(cherry picked from commit 416caeb)
Configuration menu - View commit details
-
Copy full SHA for 382b2db - Browse repository at this point
Copy the full SHA 382b2dbView commit details -
https://golang.org/doc/devel/release.html#go1.14.minor (cherry picked from commit 8d41f9f)
Configuration menu - View commit details
-
Copy full SHA for 2a1c67c - Browse repository at this point
Copy the full SHA 2a1c67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 203fcba - Browse repository at this point
Copy the full SHA 203fcbaView commit details -
https://golang.org/doc/devel/release.html#go1.13.minor (cherry picked from commit 7da08af)
Configuration menu - View commit details
-
Copy full SHA for b1cbd08 - Browse repository at this point
Copy the full SHA b1cbd08View commit details -
https://golang.org/doc/devel/release.html#go1.14.minor (cherry picked from commit 9f97814)
Configuration menu - View commit details
-
Copy full SHA for 16a461d - Browse repository at this point
Copy the full SHA 16a461dView commit details -
go: fix TestDontCacheBrokenHTTP2Conn failure
(cherry picked from commit aae680c)
Configuration menu - View commit details
-
Copy full SHA for 4094b36 - Browse repository at this point
Copy the full SHA 4094b36View commit details -
buildGoModule: passthru the modSha256 (#82027)
The builder does not technically need the modSha256 of the vendor dir, and even though we pass it the entire vendor dir it makes sense not to risk having an accidental dependency on that variable. However, tools like [nixpkgs-update](https://github.com/ryantm/nixpkgs-update) need to inspect the `modSha256` of a package in order to be able to update them, and since this is a real part of the package (describes info about its dependencies) let's add it to `passthru`. Specifically, this allows us to run a cmd like `nix eval -f . tflint.modSha256` to get the current value, which is how the bot finds it to replace with the new version in the Rust ecosystem. (cherry picked from commit 5f77ff6)
Configuration menu - View commit details
-
Copy full SHA for 9ae22e3 - Browse repository at this point
Copy the full SHA 9ae22e3View commit details -
go-modules: Augment builds w/ vendor src
This is done in response to complaints that the module format is not human readable. The vendor source blob is flat files and should be extremely readable. (cherry picked from commit 9761128)
Configuration menu - View commit details
-
Copy full SHA for 470d555 - Browse repository at this point
Copy the full SHA 470d555View commit details -
go-modules: Add in old modsha256 w/ warning
(removed warning for 20.03) (cherry picked from commit a0ddea1)
Configuration menu - View commit details
-
Copy full SHA for 124d70c - Browse repository at this point
Copy the full SHA 124d70cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.