Remove science_support attribute for compsets #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLOM/iHAMOCC compsets will no longer have science_support attributes in connection with the noresm2.1 release.
Remove science_support attribute for compsets
TomasTorsvik
requested review from
matsbn,
mvertens,
milicak,
JorgSchwinger and
jmaerz
TomasTorsvik
added
iHAMOCC
JorgSchwinger
approved these changes
Dec 12, 2023
|
I will go ahead with this PR. If for some reason the science_support attribute is needed on master this change can easily be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
masterbranch has now diverged from CMIP6, so it would make sense to remove the science_support attribute from all compsets until a new scientifically supported NorESM version is created.Closes #320