Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU-ADD] sale_crm: Nothing to do #3996

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[16.0][OU-ADD] sale_crm: Nothing to do #3996

merged 1 commit into from
Feb 13, 2024
+7 −1

Conversation

diamondnguyenkc
Copy link
Contributor

Nothing to do

@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 3, 2023 •
edited
Loading

/ocabot migration sale_crm

Depends on :

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 3, 2023
Open
@legalsylvain legalsylvain mentioned this pull request Jul 4, 2023
Merged
robinkeunen
robinkeunen approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing to do

remytms
remytms approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3996-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 7, 2024
@OCA-git-bot
Merge PR #3996 into 16.0
f80c06d 
Signed-off-by legalsylvain
@pedrobaeza
Copy link
Member

sale module is not yet merged, so better not to merge this. Aborting. I'll check soon.

@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3996-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain
Copy link
Contributor

Thanks @pedrobaeza . sorry i didn't saw the label "blocked by dependency"

@pedrobaeza pedrobaeza merged commit 6a7ede6 into OCA:16.0 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remytms remytms remytms approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@robinkeunen robinkeunen robinkeunen approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@diamondnguyenkc @legalsylvain @OCA-git-bot @pedrobaeza @robinkeunen @remytms