Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU-ADD] sale: migration #4240

Closed
wants to merge 1 commit into from
Closed

[16.0][OU-ADD] sale: migration #4240

wants to merge 1 commit into from

Conversation

duong77476-viindoo
Copy link
Contributor

replace the work of: #4004

@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 28, 2023 •
edited
Loading

/ocabot migration sale

Depends on :

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 28, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 28, 2023
Open
@rvalyi
Copy link
Member

rvalyi commented Nov 28, 2023

great you introduced _create_ir_model_data_sale_default_invoice_email_template, default_invoice_email_template was indeed an issue in the other script I tried, I'll try this new one soon and report.

@duong77476-viindoo
Copy link
Contributor Author

great you introduced _create_ir_model_data_sale_default_invoice_email_template, default_invoice_email_template was indeed an issue in the other script I tried, I'll try this new one soon and report.

Oki thank you

marielejeune
marielejeune reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking this huge work again!
Here is an error that I noticed.

openupgrade_scripts/scripts/sale/16.0.1.2/pre-migration.py Outdated Show resolved Hide resolved
@marielejeune marielejeune mentioned this pull request Nov 30, 2023
Merged
legalsylvain
legalsylvain reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duong77476-viindoo. Thanks for finish this work.

Could you update the file ./docsource/modules150-160.rst, marking the sale module as done ?

@duong77476-viindoo
Copy link
Contributor Author

Hi @duong77476-viindoo. Thanks for finish this work.

Could you update the file ./docsource/modules150-160.rst, marking the sale module as done ?

Done

This was referenced Jan 12, 2024
Merged
Merged
Merged
Merged
Open
Closed
Merged
@pedrobaeza pedrobaeza changed the title [OU-ADD][16.0] sale: migration [16.0][OU-ADD] sale: migration Feb 13, 2024
@pedrobaeza pedrobaeza mentioned this pull request Feb 13, 2024
Merged
@pedrobaeza
Copy link
Member

Continue in #4301 for last touches before merging. Thanks for the hard work, @duong77476-viindoo

The attribution has been respected.

@pedrobaeza pedrobaeza closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marielejeune marielejeune marielejeune left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@legalsylvain legalsylvain legalsylvain left review comments

@fkantelberg fkantelberg fkantelberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@duong77476-viindoo @legalsylvain @rvalyi @pedrobaeza @fkantelberg @marielejeune @OCA-git-bot