[16.0][OU-ADD] account: Migration

[ngochung207]

Video test localhost:
https://youtu.be/f1vUk11DpiU

[duong77476-viindoo]

Partial everybody :v

[duong77476-viindoo]

Todo: a dynamic way to fill anaylytic_distribution on account.move.line, sale.order.line for short is any model that inherit from analytic.mixin

[legalsylvain]

/ocabot migration account

Depends on :

• analytic : [16.0][OU-ADD] analytic: Migration done #4052

[legalsylvain]

@remytms could you take a look here ?

[duong77476-viindoo]

@remytms could you take a look here ?

This PR haven't ready yet , but still me and my friend welcome all reviews from anybody especially on the analysis file

[legalsylvain]

@duong77476. No need to write dependencies message. It will be done automatically by this script. (and the list will be updated regularly). #3979
thanks !
Note : You can put your PR in a draft state when the work is not ready to review.

[duong77476-viindoo]

@duong77476. No need to write dependencies message. It will be done automatically by this script. (and the list will be updated regularly). #3979 thanks ! Note : You can put your PR in a draft state when the work is not ready to review.

Okay, thanks, just a normal habit of me when a PR need to depend on something, cool tool btw keep it up

[legalsylvain]

cool tool btw keep it up

thanks !
Well, when there are 100 PR per week (!), It's starting to become mandatory to be able to find your way around.

[duong77476-viindoo]

@legalsylvain Do you have tools that allow to rebase automatically, as many PRs are coming , i always have to do it manually :((

[legalsylvain]

@legalsylvain Do you have tools that allow to rebase automatically, as many PRs are coming , i always have to do it manually :((

You can call ocabot rebase (with \ before.)

If you have write access on the branch of the PR, it should work. Can you try ?

[duong77476-viindoo]

\ocabot

ocabot rebase

Not working.
IMO, the person who has write access to his/her PR should be able to call that

[OCA-git-bot]

Sorry @duong77476 you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[ngochung207]

@OCA-git-bot rebase

[ngochung207]

/ocabot rebase

[OCA-git-bot]

Sorry @ngochung207 you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[duong77476-viindoo]

Thanks @chrisandrewmann . But as you can see someone else has attempted and worked. If you could provide a video , show me your odoo conf as well, i might be able to check it out. Otherwise , i really hard for me though

[chrisandrewmann]

Apologies @duong77476 my mistake.
Was not loading openupgrade framework correctly in conf! Working well now.

[duong77476-viindoo]

Apologies @duong77476 my mistake. Was not loading openupgrade framework correctly in conf! Working well now.

Thank you very much, let's me know if something wrong or need improvement.

[sbidoul]

I got insert or update on table "account_analytic_line" violates foreign key constraint "account_analytic_line_journal_id_fkey" on this update.

We should probably drop the foreign key constraint before applying this:
ALTER TABLE account_analytic_line DROP CONSTRAINT IF EXISTS account_analytic_line_journal_id_fkey;

Because that constraints from v15 and earlier relates to analytic journals.

[sbidoul]

Another issue I've encountered around here is with analytic lines linked to the Timesheets Journal, which prevent the journal_id foreign key to apply. I've set journal_id to NULL on these records as a workaround. Not sure where the best place to do that is.

[remi-filament]

Hi @ngochung207 Thanks for your work !
I just tested it and found out that this rename is not done (since not called in migrate function below AFAICT).

You may want to add a openupgrade.rename_xmlids(env.cr, _xmlids_renames) to enforce it !

[duong77476-viindoo]

I know, i have postpone the work from this PR, you may want to try at https://github.com/Viindoo/OpenUpgrade , my work has finished there

[remi-filament]

Thanks @duong77476 I manage to fully migrate my database using both your repo and PRs from OCA/OpenUpgrade repo. It is however very difficult to track differences since this PR and your repo contain a lot of things which are related to your instances / modules.
Could you please let me know your plans to complete/cleanup this PR ? I can help if needed !
Best Regards

[ahshakir]

Hi,
I have been using OpenUpgrade to migrate from version 11 to version 16. So far till version 15 everything works fine and I know the migration script for 16 is not completely ready yet but I have to complete this migration so I collected the migration scripts from different repos to use and for account module I used script from here. Now the problem is after migration I tried to view the invoices and the invoice lines are not being displayed for some reason. Kindly advise please to rectify this. Thank you in advance.

[duong77476-viindoo]

Hi, I have been using OpenUpgrade to migrate from version 11 to version 16. So far till version 15 everything works fine and I know the migration script for 16 is not completely ready yet but I have to complete this migration so I collected the migration scripts from different repos to use and for account module I used script from here. Now the problem is after migration I tried to view the invoices and the invoice lines are not being displayed for some reason. Kindly advise please to rectify this. Thank you in advance.

Thanks, you may want to try at https://github.com/Viindoo/OpenUpgrade instead

[ahshakir]

Hi, I have been using OpenUpgrade to migrate from version 11 to version 16. So far till version 15 everything works fine and I know the migration script for 16 is not completely ready yet but I have to complete this migration so I collected the migration scripts from different repos to use and for account module I used script from here. Now the problem is after migration I tried to view the invoices and the invoice lines are not being displayed for some reason. Kindly advise please to rectify this. Thank you in advance.

Thanks, you may want to try at https://github.com/Viindoo/OpenUpgrade instead

I tried them too but still it didn't work as expected. Also did you come across the same error as mine after migration? And do you think is there any other way possibly I could try to fix this issue please. I am in real need of this fix right now.

[duong77476-viindoo]

@ahshakir no unfortunately, do you have any custom module beside odoo module ?

[ahshakir]

@ahshakir no unfortunately, do you have any custom module beside odoo module ?

Yes I do and I upgraded them too. Though some modules created new fields in account but nothing sort of doing major change in them And all other modules working fine except for account.

[duong77476-viindoo]

@ahshakir OK now go to debug mode, check the Edit form view then see the view architecture of account_move to see anything strange

[ahshakir]

I did not see anything strange. but what I would like to add is
The table names in account in Odoo 11,
account invoice - Invoices
account invoice line - Invoice Lines
account move - Journal Entry
account move line - Journal Items
and from Odoo 13, Invoices had name changed from account invoice to account move and from there Invoices, Journal Entries everything feeds into same table if I am not wrong.
Now coming to version 16 Invoices and Journal Entries are in account move and in the db also everything is in the place but still unable to view them. Also there is field in move line I saw display_type. does it have anything to do with the invoices?

[ikus060]

@duong77476 I wish to test your migration script, but I'm block by the migration of "payment". Do you happen to have a branch somewhere with both of these changes ?

As recommended, I already tried to upgrade by using https://github.com/Viindoo/OpenUpgrade But it it's failing the same way.

[duong77476-viindoo]

@duong77476 I wish to test your migration script, but I'm block by the migration of "payment". Do you happen to have a branch somewhere with both of these changes ?

As recommended, I already tried to upgrade by using https://github.com/Viindoo/OpenUpgrade But it it's failing the same way.

What is blocking exactly , show me error on your console log if you have any ? i have tried on a production database and it works fine

[ikus060]

Here the relevant part where the migration is failing. But it's not related to "account" migration. It's the "payment" migration that is failing.

odoo.log

Thanks for your help.

[duong77476-viindoo]

I did not see anything strange. but what I would like to add is The table names in account in Odoo 11, account invoice - Invoices account invoice line - Invoice Lines account move - Journal Entry account move line - Journal Items and from Odoo 13, Invoices had name changed from account invoice to account move and from there Invoices, Journal Entries everything feeds into same table if I am not wrong. Now coming to version 16 Invoices and Journal Entries are in account move and in the db also everything is in the place but still unable to view them. Also there is field in move line I saw display_type. does it have anything to do with the invoices?

Sorry, it is very complex when running migration all the way up from 11 to 16. I have ran it from 10 to 14 already, i must tell you that is not an easy thing to do. You will have to make sure each migration jump (11 -> 12, 12->13, ...) work smootly

[duong77476-viindoo]

Here the relevant part where the migration is failing. But it's not related to "account" migration. It's the "payment" migration that is failing.

odoo.log

Thanks for your help.

Please , check your odoo 16 CE addons, why the log said base.module_payment_abs not found, strange

[ikus060]

Please , check your odoo 16 CE addons, why the log said base.module_payment_aps not found, strange

The module payment_aps seams to be a new module in Odoo v16.0. My database doesn't have any entry in table ir_module_module for this new module. Not sure if a script should be responsible to create an entry for it !?

[ahshakir]

I did not see anything strange. but what I would like to add is The table names in account in Odoo 11, account invoice - Invoices account invoice line - Invoice Lines account move - Journal Entry account move line - Journal Items and from Odoo 13, Invoices had name changed from account invoice to account move and from there Invoices, Journal Entries everything feeds into same table if I am not wrong. Now coming to version 16 Invoices and Journal Entries are in account move and in the db also everything is in the place but still unable to view them. Also there is field in move line I saw display_type. does it have anything to do with the invoices?

Sorry, it is very complex when running migration all the way up from 11 to 16. I have ran it from 10 to 14 already, i must tell you that is not an easy thing to do. You will have to make sure each migration jump (11 -> 12, 12->13, ...) work smootly

I didn't check thoroughly with everything working smoothly while migrating to every version but I do checked if the invoices were visible properly in every migration and they were there. Only in version 16 they weren't visible at all. ALSO compared the columns in version 15 and 16 of table account.move and didn't find anything different between them.

Is there anyone here migrated to 16 and came across something similar to what I found??

[duong77476-viindoo]

Please , check your odoo 16 CE addons, why the log said base.module_payment_aps not found, strange

The module payment_aps seams to be a new module in Odoo v16.0. My database doesn't have any entry in table ir_module_module for this new module. Not sure if a script should be responsible to create an entry for it !?

No, i dont think because of the script, here is the config that i have used to run migration script. I use eclipse as an IDE to run this, of course you will need to make sure both odoo 15 and odoo 16 CE has the latest code
--addons-path=/git/odoo16/addons,/git/Openupgrade16
--load=base,web,openupgrade_framework
--limit-time-real=10000000
--http-port=8016
-d oca1
-u all
--upgrade-path=~/git/Openupgrade16/openupgrade_scripts/scripts

[duong77476-viindoo]

I did not see anything strange. but what I would like to add is The table names in account in Odoo 11, account invoice - Invoices account invoice line - Invoice Lines account move - Journal Entry account move line - Journal Items and from Odoo 13, Invoices had name changed from account invoice to account move and from there Invoices, Journal Entries everything feeds into same table if I am not wrong. Now coming to version 16 Invoices and Journal Entries are in account move and in the db also everything is in the place but still unable to view them. Also there is field in move line I saw display_type. does it have anything to do with the invoices?

Sorry, it is very complex when running migration all the way up from 11 to 16. I have ran it from 10 to 14 already, i must tell you that is not an easy thing to do. You will have to make sure each migration jump (11 -> 12, 12->13, ...) work smootly

I didn't check thoroughly with everything working smoothly while migrating to every version but I do checked if the invoices were visible properly in every migration and they were there. Only in version 16 they weren't visible at all. ALSO compared the columns in version 15 and 16 of table account.move and didn't find anything different between them.

Is there anyone here migrated to 16 and came across something similar to what I found??

Maybe try inspect (f12) to see if it still there. You mean not visible here is the tab Invoice Line is missing right ?

[pedrobaeza]

Thanks to the Viindoo pioneers on this difficult task.

I have performed the following changes and push in this PR (as there are permissions to maintainers granted):

• Don't load non useful noupdate_changes.
• Precompute account.payment~amount_company_currency_signed for the easy case of same currency.
• Preserve old account.move~auto_post column.
• Adapt account.account~account_type filling SQL and add a fallback.
• Fill properly account.account~include_initial_balance.
• No need of fast filling account.analytic.line~journal_id.
• Adapt account_analytic_distribution_model generation SQL.
• Adapt analytic_distribution SQL filling and make it generic.

I'm merging as soon as this is green, so finally! 🎉

[duong77476-viindoo]

Thanks to the Viindoo pioneers on this difficult task.

I have performed the following changes and push in this PR (as there are permissions to maintainers granted):

• Don't load non useful noupdate_changes.
• Precompute account.payment~amount_company_currency_signed for the easy case of same currency.
• Preserve old account.move~auto_post column.
• Adapt account.account~account_type filling SQL and add a fallback.
• Fill properly account.account~include_initial_balance.
• No need of fast filling account.analytic.line~journal_id.
• Adapt account_analytic_distribution_model generation SQL.
• Adapt analytic_distribution SQL filling and make it generic.

I'm merging as soon as this is green, so finally! 🎉

At your service sir 🙉
Thank you for your work too