Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] account_payment: Nothing to do #3920

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

remytms
Copy link
Contributor

@remytms remytms commented Jun 20, 2023

All the needed work is done in the pre-migration script of the payment module.

All the needed work is done in the pre-migration script of the `payment`
module.
@remytms
Copy link
Contributor Author

remytms commented Jun 20, 2023

Related to this PR: #3918

@legalsylvain
Copy link
Contributor

legalsylvain commented Jun 20, 2023

/ocabot migration account_payment

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza
Copy link
Member

Such hook is creating automatically an account.payment.method:

https://github.com/odoo/odoo/blob/16.0/addons/account_payment/models/payment_provider.py#L77

I think that's needed for migration, as we should have already created them in the previous version, but a double confirmation is interesting.

@Meisolsson
Copy link

Hi,

I've tested this. For the "standard" payment providers it's fine since they included the method data in XML. But if you for instance created a provider manually in version 14 that provider will not have a method created i version 15 och 16. By that we should probably do that migration in 14 -> 15 and this can stay as is.

@Meisolsson
Copy link

Actually there is one problem here but it comes from an failure in 14 -> 15. Relevant issue here: #4257.

@mostafabarmshory
Copy link

Dear all,
This is not marked as a fixed task in Migration to version 16.0. Is it required to be checked? Can you give a feedback?

@remytms
Copy link
Contributor Author

remytms commented Feb 8, 2024

Since the issue raised by @chienandalu was fixed in 15.0 by @Meisolsson, I think that this PR can be validated. Do you agree ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit eb5d096 into OCA:16.0 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants