-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][OU-ADD] account_payment: Nothing to do #3920
Conversation
All the needed work is done in the pre-migration script of the `payment` module.
Related to this PR: #3918 |
/ocabot migration account_payment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we take care of this new init hook?: https://github.com/odoo/odoo/blob/16.0/addons/account_payment/__init__.py#L16
Such hook is creating automatically an https://github.com/odoo/odoo/blob/16.0/addons/account_payment/models/payment_provider.py#L77 I think that's needed for migration, as we should have already created them in the previous version, but a double confirmation is interesting. |
Hi, I've tested this. For the "standard" payment providers it's fine since they included the method data in XML. But if you for instance created a provider manually in version 14 that provider will not have a method created i version 15 och 16. By that we should probably do that migration in 14 -> 15 and this can stay as is. |
Actually there is one problem here but it comes from an failure in 14 -> 15. Relevant issue here: #4257. |
Dear all, |
Since the issue raised by @chienandalu was fixed in 15.0 by @Meisolsson, I think that this PR can be validated. Do you agree ? |
This PR has the |
All the needed work is done in the pre-migration script of the
payment
module.