Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ENH] account_asset_transfer: add feature expand asset line #1322

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[14.0][ENH] account_asset_transfer: add feature expand asset line #1322

merged 2 commits into from
Sep 19, 2023

Conversation

ps-tubtim
Copy link
Member

@ps-tubtim ps-tubtim commented Jan 20, 2022 •
edited
Loading

This module adds a feature to expand the asset line on the transfer wizard.

Note: The system just helps to expand the line that selects the asset profile set to be "Create an asset by product item".

Wizard
Selection_124

Example
expand_asset

@kittiu
Copy link
Member

kittiu commented Jan 26, 2022

Since this is a small enhance. Should this be included in account_asset_transfer

@ps-tubtim ps-tubtim force-pushed the 14.0-enh-account_asset_transfer branch 2 times, most recently from 2494e82 to 95a0540 Compare January 27, 2022 20:04
@ps-tubtim ps-tubtim changed the title [14.0][ADD] account_asset_transfer_enhance [14.0][ENH] account_asset_transfer: add feature expand asset line Jan 27, 2022
@ps-tubtim
Copy link
Member Author

@kittiu I already updated this pull request.

@ps-tubtim ps-tubtim force-pushed the 14.0-enh-account_asset_transfer branch from 95a0540 to e334e8c Compare January 27, 2022 20:29
@ps-tubtim ps-tubtim force-pushed the 14.0-enh-account_asset_transfer branch 3 times, most recently from 6f0c5d5 to 7d31331 Compare October 5, 2022 10:53
@Saran440 Saran440 force-pushed the 14.0-enh-account_asset_transfer branch from bcfc521 to 52fb260 Compare October 18, 2022 08:03
Saran440
Saran440 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍 and add test script

@Saran440 Saran440 force-pushed the 14.0-enh-account_asset_transfer branch from 52fb260 to 5830d24 Compare October 18, 2022 08:17
@ps-tubtim ps-tubtim force-pushed the 14.0-enh-account_asset_transfer branch 2 times, most recently from bbcffd7 to 4329bd9 Compare December 22, 2022 10:23
@ps-tubtim ps-tubtim force-pushed the 14.0-enh-account_asset_transfer branch from 4329bd9 to dd17cd4 Compare February 13, 2023 08:59
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kittiu
Copy link
Member

kittiu commented Sep 19, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1322-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1322-by-kittiu-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
@OCA-git-bot
Merge PR #1322 into 14.0
fa81abb 
Signed-off-by kittiu
@OCA-git-bot OCA-git-bot merged commit 1e1732a into OCA:14.0 Sep 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f3b8344. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1322-by-kittiu-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f3b8344. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@kittiu kittiu kittiu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps-tubtim @kittiu @OCA-git-bot @Saran440