Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_asset_transfer #1507

Merged
merged 12 commits into from
Sep 20, 2023
Merged

[15.0][MIG] account_asset_transfer #1507

merged 12 commits into from
Sep 20, 2023

Conversation

TheerayutEncoder
Copy link

Standard Migration 15.0 👍

@TheerayutEncoder
Copy link
Author

@Saran440 @newtratip
Could you help review this PR?

@Saran440
Copy link
Member

Saran440 commented Dec 2, 2022

@TheerayutEncoder please add test script to cover case.

@ps-tubtim
Copy link
Member

@TheerayutEncoder Please separate the commits following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 and add you to CONTRIBUTORS.rst.

@Saran440 Saran440 force-pushed the 15.0-mig-account_asset_transfer branch from de7580b to dcfc99f Compare February 17, 2023 04:39
@Saran440 Saran440 mentioned this pull request Feb 17, 2023
Merged
2 tasks
@ps-tubtim ps-tubtim mentioned this pull request Apr 5, 2023
Merged
1 task
Saran440
Saran440 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ps-tubtim ps-tubtim mentioned this pull request May 17, 2023
Merged
1 task
@Saran440
Copy link
Member

  • Add source/dest in asset transfer
    Selection_012

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow
Copy link
Contributor

Please cherry-pick dd17cd4 (comes from #1322)

@Saran440
Copy link
Member

@MiquelRForgeFlow Hi,
we add it already 8c5195d

Thank you for your review.

@kittiu
Copy link
Member

kittiu commented Sep 20, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1507-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3133b73 into OCA:15.0 Sep 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa97065. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@Saran440 Saran440 Saran440 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TheerayutEncoder @Saran440 @ps-tubtim @OCA-git-bot @MiquelRForgeFlow @kittiu @oca-travis @victoralmau