8.0 Add support for partner bank matching on invoice update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as only supported on invoice creation)
pedrobaeza
reviewed
Oct 5, 2016
| iban = iban.replace(' ', '') | ||
| rpbo = self.env['res.partner.bank'] | ||
| self._cr.execute( | ||
| """SELECT id FROM res_partner_bank |
There was a problem hiding this comment.
I need the replace() method in SQL because the IBAN can have spaces in res_partner_bank. In v9, this problem is solved by the acc_number_sanitized field, so I will remove this SQL request in v9 and use the ORM instead.
pedrobaeza
reviewed
Oct 5, 2016
| 'acc_number': iban, | ||
| 'bank_bic': bic, | ||
| }) | ||
| chatter_msg.append(_( |
There was a problem hiding this comment.
You have to modify the translations due to this file change I think
There was a problem hiding this comment.
Translations are handled automatically via transifex, no ?
There was a problem hiding this comment.
Yes, but you will lose any of the already present translations. It's just to check and modify translation files to see the comment line about the code that contains this sentence.
There was a problem hiding this comment.
There are no translation for this module so far.
pedrobaeza
reviewed
Oct 5, 2016
| @@ -238,6 +238,36 @@ def _match_shipping_partner(self, shipping_dict, partner, chatter_msg): | |||
| return partner | |||
|
|
|||
| @api.model | |||
| def _match_partner_bank( | |||
| self, partner, iban, bic, chatter_msg, create_if_not_found=False): | |||
There was a problem hiding this comment.
To make it more tolerant, put chatter_msg as optional.
There was a problem hiding this comment.
Mmm, it is that way in all the other methods of this module.
There was a problem hiding this comment.
But you can start with this one being more tolerant 😉 for reusing it in models without chatter.
There was a problem hiding this comment.
When I'll change that, I'll change it everywhere ; I don't want to do it partially.
There was a problem hiding this comment.
This is a good moment for that 😉, but I know that you're not going to do it, hehe
I didn't update sale_commercial_partner because this module will have to be moved to sale-workflow
|
@alexis-via, what are the plans for bringing this to v9? |
|
I'll port it to v10 in December 2016 or January 2017 (when my customers will go live on v10) ; I don't want to start the port too early because I still have things that I want to change on v8 and I would like to avoid too much backporting work. The 2 points I want to address are:
I don't have any plans for v9, but my port to v10 should be compatible with v9 I guess. |
|
OK, thanks for sharing your plans. I'm not sure how to act because we need it on v9, but only for commodity (not mandatory requirement), but we want it now. I'll tell you later. |
sebastienbeau
approved these changes
Oct 18, 2016
njeudy
pushed a commit
to njeudy/edi
that referenced
this pull request
Jan 27, 2018
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
njeudy
pushed a commit
to njeudy/edi
that referenced
this pull request
Jan 27, 2018
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
hbrunn
pushed a commit
that referenced
this pull request
Feb 21, 2018
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
njeudy
pushed a commit
to njeudy/edi
that referenced
this pull request
Oct 2, 2018
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
astirpe
pushed a commit
to njeudy/edi
that referenced
this pull request
Oct 12, 2018
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
aronabencherif
pushed a commit
to xcgd/edi
that referenced
this pull request
Nov 7, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
IT-Ideas
pushed a commit
to acsone/edi
that referenced
this pull request
Nov 23, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 11, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 15, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
thienvh332
pushed a commit
to camptocamp/edi
that referenced
this pull request
Dec 28, 2023
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
JaumeBforgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Jan 22, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
JaumeBforgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Jan 22, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
gurneyalex
pushed a commit
to gurneyalex/edi
that referenced
this pull request
Feb 20, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
nguyenminhchien
pushed a commit
to nguyenminhchien/edi
that referenced
this pull request
Feb 20, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
nguyenminhchien
pushed a commit
to nguyenminhchien/edi
that referenced
this pull request
Feb 20, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Wodran14
pushed a commit
to DynAppsNV/edi
that referenced
this pull request
Jun 3, 2024
PEP8 fix 8.0 Add support for partner bank matching on invoice update (OCA#6) Add support for partner bank matching on invoice update (before, it was only supported on invoice creation) 8.0 Use try/except when importing external libs (OCA#8) [FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
Wodran14
pushed a commit
to DynAppsNV/edi
that referenced
this pull request
Jun 4, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
antonioburic
pushed a commit
to antonioburic/edi
that referenced
this pull request
Jul 8, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 4, 2024
Add ecino as switzerland maintainer
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 4, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 4, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
HeliconiaSolutions
pushed a commit
to HeliconiaIO/edi
that referenced
this pull request
Dec 9, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
baguenth
referenced
this pull request
in AmetrasIntelligence/edi
Dec 10, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 11, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 11, 2024
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for partner bank matching on invoice update. Before, this feature was only supported on invoice creation. I developed this new feature this afternoon for my demo at my Odoo experience conference.