8.0 Use try/except when importing external libs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove self.ensure_one() that has nothing to do in an api.model method
moylop260
requested changes
Oct 18, 2016
There was a problem hiding this comment.
Thanks for your PR
Could you create a requirements.txt in the root of the project (MQT automatically use it to install dependencies) and remove pip install from .travis.yml file?
| from invoice2data.template import read_templates | ||
| from invoice2data.main import logger as loggeri2data | ||
| except ImportError: | ||
| logger.warning('Cannot import invoice2data') |
There was a problem hiding this comment.
s/warning/debug/g
Like as our example from guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#importerror
| from PyPDF2.generic import DictionaryObject, DecodedStreamObject,\ | ||
| NameObject, createStringObject, ArrayObject | ||
| except ImportError: | ||
| logger.warning('Cannot import PyPDF2') |
pedrobaeza
approved these changes
Oct 19, 2016
njeudy
pushed a commit
to njeudy/edi
that referenced
this pull request
Jan 27, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
njeudy
pushed a commit
to njeudy/edi
that referenced
this pull request
Jan 27, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
hbrunn
pushed a commit
that referenced
this pull request
Feb 21, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
astirpe
pushed a commit
to njeudy/edi
that referenced
this pull request
Oct 12, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
tarteo
pushed a commit
to tarteo/edi
that referenced
this pull request
Oct 31, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
antoinecln
pushed a commit
to antoinecln/edi
that referenced
this pull request
Nov 23, 2018
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
referenced
this pull request
in akretion/edi
Mar 4, 2019
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
referenced
this pull request
in akretion/edi
Mar 4, 2019
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
rubdos
pushed a commit
to rubdos/edi
that referenced
this pull request
Mar 9, 2019
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
MiquelRForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Mar 13, 2019
PEP8 fix 8.0 Add support for partner bank matching on invoice update (OCA#6) Add support for partner bank matching on invoice update (before, it was only supported on invoice creation) 8.0 Use try/except when importing external libs (OCA#8) [FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
pushed a commit
that referenced
this pull request
Dec 31, 2019
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
pushed a commit
that referenced
this pull request
Dec 31, 2019
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
pushed a commit
that referenced
this pull request
Jan 22, 2020
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
hhgabelgaard
pushed a commit
to steingabelgaard/edi
that referenced
this pull request
Mar 23, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
referenced
this pull request
in akretion/edi
Mar 24, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
ghost
pushed a commit
to gbrito/edi
that referenced
this pull request
Mar 28, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
ghost
pushed a commit
to gbrito/edi
that referenced
this pull request
Mar 28, 2023
PEP8 fix 8.0 Add support for partner bank matching on invoice update (OCA#6) Add support for partner bank matching on invoice update (before, it was only supported on invoice creation) 8.0 Use try/except when importing external libs (OCA#8) [FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
acsonefho
pushed a commit
to acsone/edi
that referenced
this pull request
Apr 25, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
alexis-via
referenced
this pull request
in akretion/edi
May 4, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
njeudy
pushed a commit
to Alusage/edi
that referenced
this pull request
May 8, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
njeudy
pushed a commit
to Alusage/edi
that referenced
this pull request
May 8, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
OCA-git-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
aronabencherif
pushed a commit
to xcgd/edi
that referenced
this pull request
Nov 7, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
thienvh332
pushed a commit
to camptocamp/edi
that referenced
this pull request
Dec 28, 2023
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
JaumeBforgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Jan 22, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
gurneyalex
pushed a commit
to gurneyalex/edi
that referenced
this pull request
Feb 20, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
nguyenminhchien
pushed a commit
to nguyenminhchien/edi
that referenced
this pull request
Feb 20, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
nguyenminhchien
pushed a commit
to nguyenminhchien/edi
that referenced
this pull request
Feb 20, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
Wodran14
pushed a commit
to DynAppsNV/edi
that referenced
this pull request
Jun 3, 2024
PEP8 fix 8.0 Add support for partner bank matching on invoice update (OCA#6) Add support for partner bank matching on invoice update (before, it was only supported on invoice creation) 8.0 Use try/except when importing external libs (OCA#8) [FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Nov 7, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
jbaudoux
pushed a commit
to jbaudoux/edi
that referenced
this pull request
Dec 4, 2024
[UPD] change default_branch to 17.0
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 5, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
HeliconiaSolutions
pushed a commit
to HeliconiaIO/edi
that referenced
this pull request
Dec 9, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
baguenth
pushed a commit
to AmetrasIntelligence/edi
that referenced
this pull request
Dec 10, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 11, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
V3st1g3
pushed a commit
to V3st1g3/oca-edi
that referenced
this pull request
Dec 11, 2024
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove self.ensure_one() that has nothing to do in an api.model method
Fix bug #7