Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldservicemodule abusive dependencies? #674

Closed
dreispt opened this issue Nov 20, 2020 · 7 comments
Closed

fieldservicemodule abusive dependencies? #674

dreispt opened this issue Nov 20, 2020 · 7 comments
Labels

Comments

@dreispt
Copy link
Member

dreispt commented Nov 20, 2020

I note that the fieldservice has dependencies on modules that don't seem necessary for it to work.
For example, partner_fax and web_timeline.
In my opinion if they not essential, the installation of those modules should be optional, and not be in the dependencies.
Such a change is simple wouldn't have an impact on existing installations.

@pedrobaeza
Copy link
Member

Yeah, I agree and don't see the connection.

@bodedra
Copy link
Member

bodedra commented Nov 20, 2020

timeline view functionality provided by web_timeline module and v12 fieldservice module has used timeline functionality.

In v13 fieldservice module has dropped that functionality. I will share discussion link for reason.

@brian10048
Copy link
Contributor

web_timeline has already been separated as of v13
Agreed that partner_fax isn't very essential either

While we are on the subject of dependencies...
I feel that the fieldservice_stock module has extra dependencies on some OCA stock_request modules. For me it would be better to split into one module that depends on base stock module and another one for the stock_request modules. I'll do the work to split up fieldservice_stock if others are OK with that change

@pedrobaeza
Copy link
Member

Yes, please!

@bodedra
Copy link
Member

bodedra commented Nov 20, 2020

I take my words back for dropped functionality. It actually timeline functionality separated in new module called fieldservice_timeline. Here is open PR #521

@bodedra
Copy link
Member

bodedra commented Nov 20, 2020

@dreispt For fieldservice v13, we can remove dependency of partner_fax and web_timeline modules.

@hparfr
Copy link
Contributor

hparfr commented Jan 14, 2021

base_territory can be removed too I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants