-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify fieldservice_stock #675
Conversation
Hi @wolfhall, @smangukiya, @max3903, |
94daa21
to
1dc7cca
Compare
1dc7cca
to
1c4a5fb
Compare
e7630fb
to
6bb9288
Compare
Minimize dependency on stock_request
Remove the equipment related functionality from the fieldservice_stock module and make into separate module
6bb9288
to
6a63af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge major |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 7468669. Thanks a lot for contributing to OCA. ❤️ |
File was moved in OCA#675
@brian10048 Next time you refactor like this, please provide the migration script to cleanup views. Thank you. |
My apologies @max3903. I hope I didn't cause your team too much trouble Would using rename_xmlids from openupgradelib have been correct? |
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
File was moved in OCA#675
#674
The module fieldservice_stock has grown to include extra dependencies and features that may not be necessary for all use cases. This PR will help to:
stock_request_*
dependencies and simplify to only depend on Odoostock