Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fieldservice_stock #675

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Conversation

brian10048
Copy link
Contributor

@brian10048 brian10048 commented Nov 21, 2020

#674

The module fieldservice_stock has grown to include extra dependencies and features that may not be necessary for all use cases. This PR will help to:

  • remove stock_request_* dependencies and simplify to only depend on Odoo stock
  • remove FSM Equipment related functions and move to own module
  • add tests for all affected modules
  • update readmes accordingly

@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @smangukiya, @max3903,
some modules you are maintaining are being modified, check this out!

@brian10048 brian10048 self-assigned this Nov 21, 2020
@brian10048 brian10048 force-pushed the imp-fsm-split-stock branch 2 times, most recently from 94daa21 to 1dc7cca Compare November 21, 2020 21:18
@max3903 max3903 added this to the 12.0 milestone Dec 14, 2020
@brian10048 brian10048 force-pushed the imp-fsm-split-stock branch 10 times, most recently from e7630fb to 6bb9288 Compare January 16, 2021 01:23
@brian10048 brian10048 marked this pull request as ready for review January 16, 2021 01:24
Minimize dependency on stock_request
Remove the equipment related functionality from the fieldservice_stock module and make into separate module
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review.

Copy link

@smangukiya smangukiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@brian10048
Copy link
Contributor Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-675-by-brian10048-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 85418f8 into OCA:12.0 Mar 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7468669. Thanks a lot for contributing to OCA. ❤️

brian10048 added a commit to brian10048/field-service that referenced this pull request Mar 10, 2021
@max3903
Copy link
Member

max3903 commented Apr 1, 2021

@brian10048 Next time you refactor like this, please provide the migration script to cleanup views. Thank you.

@brian10048
Copy link
Contributor Author

My apologies @max3903. I hope I didn't cause your team too much trouble

Would using rename_xmlids from openupgradelib have been correct?

@brian10048 brian10048 deleted the imp-fsm-split-stock branch April 2, 2021 14:39
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Jul 6, 2021
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Jul 6, 2021
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Jul 6, 2021
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Jul 20, 2021
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Aug 18, 2021
ReedHayashikawa pushed a commit to ursais/field-service that referenced this pull request Aug 18, 2021
Vandan-OSI pushed a commit to ursais/field-service that referenced this pull request Mar 25, 2022
Vandan-OSI pushed a commit to ursais/field-service that referenced this pull request Oct 28, 2022
Vandan-OSI pushed a commit to ursais/field-service that referenced this pull request Nov 11, 2022
max3903 pushed a commit to ursais/field-service that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants