-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] [IMP] fieldservice: Minimize partner_fax dependency #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian10048
requested review from
dreispt,
marcelsavegnago,
hparfr and
bodedra
January 17, 2021 13:31
brian10048
force-pushed
the
13.0-partner-fax
branch
from
January 17, 2021 13:37
9a201a1
to
18414a3
Compare
hparfr
approved these changes
Jan 18, 2021
hparfr
requested changes
Jan 18, 2021
brian10048
force-pushed
the
13.0-partner-fax
branch
from
January 18, 2021 12:00
18414a3
to
f10811d
Compare
bodedra
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. 👍
bodedra
reviewed
Jan 18, 2021
Added a separate module to retain the partner_fax feature and eliminated the dependency from the base fieldservice module
brian10048
force-pushed
the
13.0-partner-fax
branch
from
January 18, 2021 15:42
f10811d
to
0b844cc
Compare
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at ca9767c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#674
Added a separate module to retain the partner_fax feature and eliminated the dependency from the base fieldservice module