[IMP] fieldservice: Minor changes #491

osi-scampbell · 2020-01-29T22:00:26Z

When a user changes the Internal Reference on a FSM Location, the complete_name field is not updated. Since it is part of the complete_name field, I believe it should update when changed.

Ticket #1499

When a user changes the Template we only set Type if it is False. We also want to append to the existing description instead of overwriting it when copyting notes.

Ticket #1679

When a user pulls up a tree view, enables a group_by filter, selects a record, then selects a smartbutton, if that group_by field is not on the corresponding smart_button object then a KeyError will be thrown. This is resolved by removing the group_by key from the context dictionary after it is copied.

Ticket #1336

On FSO's when a user sets the Location, the directions are then copied into the Location Directions on the FSO properly. However, whenever the call_notes() is called, it duplicates the Location Directions. The only thing that should be in this field are the directions from the assigned FSM Location.

Ticket #1854

On FSO's users were moving the Kanban cards and not triggering the logic that is stored in the buttons that move the stage on the form view. We prevent this by adding a boolean field that is returned True only when the button is clicked. If it is not through the button then we will throw a UserError and move the Kanban card back to its original stage

Ticket #1481

OCA-git-bot · 2020-01-29T22:00:34Z

Hi @wolfhall, @max3903,
some modules you are maintaining are being modified, check this out!

fieldservice/models/fsm_location.py

fieldservice/models/fsm_order.py

[IMP] Keep Type and Description [IMP] Clear Group By Context [IMP] Typo + Location Direction Duplicate [IMP] Prevent Kanban Completed Change [IMP] Variable Name Change locations -> contacts [IMP] Redundant Button [IMP] Clean up Notes [IMP] Cleanup Notes

fieldservice/models/fsm_location.py

fieldservice/models/fsm_order.py

patrickrwilson

Looks good.

max3903 · 2020-03-12T19:43:14Z

@brian10048 Can we merge this one?

max3903 · 2020-03-12T20:37:58Z

/ocabot merge minor

OCA-git-bot · 2020-03-12T20:38:12Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-491-by-max3903-bump-minor, awaiting test results.

OCA-git-bot · 2020-03-12T20:49:36Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2020-03-12T20:58:42Z

Congratulations, your PR was merged at effdf97. Thanks a lot for contributing to OCA. ❤️

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

Currently translated at 100.0% (469 of 469 strings) Translation: field-service-13.0/field-service-13.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice/es_AR/ [13.0] [IMP] fieldservice: Minor Changes Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

osi-scampbell requested a review from max3903 January 29, 2020 22:00

osi-scampbell requested review from smangukiya and patrickrwilson January 29, 2020 22:00

osi-scampbell changed the title ~~[IMP] Update Complete Name for Ref~~ [IMP] fieldservice minor changes Jan 29, 2020

max3903 reviewed Feb 4, 2020

View reviewed changes

fieldservice/models/fsm_location.py Show resolved Hide resolved

max3903 assigned osi-scampbell Feb 4, 2020

max3903 added enhancement needs fixing labels Feb 4, 2020

max3903 added this to the 12.0 milestone Feb 4, 2020

max3903 changed the title ~~[IMP] fieldservice minor changes~~ [IMP] fieldservice: Minor changes Feb 4, 2020

osi-scampbell force-pushed the 12.0-imp-fieldservice_ref_complete_name branch from 925d4ba to c72200f Compare February 4, 2020 22:50

max3903 approved these changes Feb 5, 2020

View reviewed changes

max3903 self-requested a review February 5, 2020 00:23

brian10048 requested changes Feb 7, 2020

View reviewed changes

fieldservice/models/fsm_order.py Outdated Show resolved Hide resolved

fieldservice/models/fsm_order.py Outdated Show resolved Hide resolved

fieldservice/models/fsm_order.py Outdated Show resolved Hide resolved

fieldservice/models/fsm_order.py Outdated Show resolved Hide resolved

osi-scampbell force-pushed the 12.0-imp-fieldservice_ref_complete_name branch from 30e8ef1 to 20f7fd7 Compare February 13, 2020 22:59

osi-scampbell added 2 commits February 13, 2020 15:00

[IMP] Remove Team

6f8940a

[IMP] Change Type From Template

3a8b949

osi-scampbell requested a review from brian10048 February 27, 2020 17:33

max3903 reviewed Feb 27, 2020

View reviewed changes

fieldservice/models/fsm_location.py Outdated Show resolved Hide resolved

brian10048 requested changes Feb 27, 2020

View reviewed changes

fieldservice/models/fsm_order.py Outdated Show resolved Hide resolved

[IMP] Rewrite Instructions + Variable Name Change

241cb62

osi-scampbell requested a review from brian10048 February 27, 2020 20:31

Update fsm_order.py

ac49e01

max3903 added needs review and removed needs fixing labels Mar 11, 2020

patrickrwilson approved these changes Mar 12, 2020

View reviewed changes

brian10048 approved these changes Mar 12, 2020

View reviewed changes

OCA-git-bot added the approved label Mar 12, 2020

OCA-git-bot added the ready to merge label Mar 12, 2020

OCA-git-bot merged commit dec841f into OCA:12.0 Mar 12, 2020

OCA-git-bot added the merged 🎉 label Mar 12, 2020

brian10048 pushed a commit to brian10048/field-service that referenced this pull request Jul 22, 2020

[13.0] [IMP] fieldservice: Minor Changes

5f06181

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

brian10048 pushed a commit to brian10048/field-service that referenced this pull request Oct 22, 2020

[13.0] [IMP] fieldservice: Minor Changes

060096b

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

brian10048 pushed a commit to brian10048/field-service that referenced this pull request Oct 26, 2020

[13.0] [IMP] fieldservice: Minor Changes

c85c754

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Jan 18, 2021

[13.0] [IMP] fieldservice: Minor Changes

be757b1

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021

[13.0] [IMP] fieldservice: Minor Changes

5fcbbf3

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

hparfr pushed a commit to akretion/field-service that referenced this pull request Mar 11, 2021

[13.0] [IMP] fieldservice: Minor Changes

a8814ca

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

AmmarOfficewalaSerpentCS pushed a commit to ursais/field-service that referenced this pull request Jan 7, 2022

[13.0] [IMP] fieldservice: Minor Changes

effba4b

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

Murtaza-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022

[13.0] [IMP] fieldservice: Minor Changes

34f98d6

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

Freni-OSI pushed a commit to ursais/field-service that referenced this pull request Apr 6, 2022

[13.0] [IMP] fieldservice: Minor Changes

acd13a2

Forward port from 12.0 Merge PR OCA#491 into 12.0 Signed-off-by max3903

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] fieldservice: Minor changes #491

[IMP] fieldservice: Minor changes #491

osi-scampbell commented Jan 29, 2020 •

edited

Loading

OCA-git-bot commented Jan 29, 2020

patrickrwilson left a comment

max3903 commented Mar 12, 2020

max3903 commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

[IMP] fieldservice: Minor changes #491

[IMP] fieldservice: Minor changes #491

Conversation

osi-scampbell commented Jan 29, 2020 • edited Loading

OCA-git-bot commented Jan 29, 2020

patrickrwilson left a comment

Choose a reason for hiding this comment

max3903 commented Mar 12, 2020

max3903 commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

OCA-git-bot commented Mar 12, 2020

osi-scampbell commented Jan 29, 2020 •

edited

Loading