[14.0] [MIG] Migrated fieldservice module. #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_id filling proper manager details while creating FS location otherwise it makes null to respective region,branch,district
context_today does not work correctly for datetime filters, it is being used durectly to compare wuth UTC stored datetimes. To get the expected results, datetime.utcmow() must be used instead. [FIX] Fix Filters [IMP] Final Fix
Fix duplicate filter names
Issue OCA#588 - FSM User group cannot view Complet button on FSM orders
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-13.0/field-service-13.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice/
Currently translated at 100.0% (487 of 487 strings) Translation: field-service-13.0/field-service-13.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-13.0/field-service-13.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice/
Currently translated at 100.0% (488 of 488 strings) Translation: field-service-13.0/field-service-13.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-13-0/field-service-13-0-fieldservice/es_AR/
hparfr
requested changes
Jan 18, 2021
| @@ -377,6 +377,8 @@ def onchange_scheduled_date_end(self): | |||
| @api.onchange("scheduled_duration") | |||
| def onchange_scheduled_duration(self): | |||
| if self.scheduled_duration and self.scheduled_date_start: | |||
| if self.scheduled_duration < 0: | |||
| raise ValidationError(_("Scheduled Duration Should be Postive Value")) | |||
There was a problem hiding this comment.
The default value is zero so no need to check = into it.
fieldservice/models/fsm_person.py
Outdated
| @@ -32,6 +34,10 @@ class FSMPerson(models.Model): | |||
| mobile = fields.Char(string="Mobile") | |||
| territory_ids = fields.Many2many("res.territory", string="Territories") | |||
|
|
|||
| message_main_attachment_id = fields.Many2one(string="Main Attachment", | |||
| def _onchange_group_fsm_equipment(self): | ||
| if not self.group_fsm_equipment: | ||
| self.auto_populate_the_equipments = False | ||
|
|
|
Hi @Murtaza-OSI do you plan to work on this pr soon ? |
|
Also please integrate the removal of partner_fax #693 |
|
Thank you for the work @Murtaza-OSI What is reason to remove the two onchange methods in res_config_settings here ? Why is the message_main_attachment_id field added in fsm_person here ? Also can you remove partner_fax like we did in #693 to keep consistency between v13 and v14? |
|
Superseded by #740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.