Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][MIG][15.0] fieldservice_vehicle_stock #921

Closed
wants to merge 41 commits into from
Closed

[WIP][MIG][15.0] fieldservice_vehicle_stock #921

wants to merge 41 commits into from

Conversation

Vandan-OSI
Copy link
Contributor

No description provided.

@Vandan-OSI Vandan-OSI marked this pull request as draft March 25, 2022 09:27
@brian10048
Copy link
Contributor

/ocabot migration fieldservice_vehicle_stock

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 24, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request May 24, 2022
Open
47 tasks
@oca-clabot
Copy link

Hey @Vandan-OSI, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@max3903 max3903 self-assigned this Oct 21, 2022
@Vandan-OSI Vandan-OSI marked this pull request as ready for review October 27, 2022 06:07
@Vandan-OSI Vandan-OSI force-pushed the 15.0-MIG-fieldservice_vehicle_stock branch 2 times, most recently from 82a2397 to abcad5b Compare October 28, 2022 10:27
@Vandan-OSI
Copy link
Contributor Author

Vandan-OSI commented Oct 28, 2022 •
edited by max3903
Loading

@max3903 @dreispt @brian10048

This PR depends on:

@Vandan-OSI Vandan-OSI force-pushed the 15.0-MIG-fieldservice_vehicle_stock branch from abcad5b to 1e862df Compare November 11, 2022 11:08
@brian10048
Copy link
Contributor

@max3903
I'm trying to understand how the putaway features of this module function and if the dependency on stock_putaway_method is still required.

Core Odoo removed the method putaway_apply after v12 and this method was where the putaway method added by stock_putaway_method gets used. During migration of this module from v12 to v14 (here) the method putaway_apply was deleted since it's no longer in core Odoo to override but the putaway feature was never replaced.

I think this module should be refactored to remove the dependency (see #945) or the dependency could be improved to once again provide the functionality putaway_apply had when it was a part of core Odoo

@brian10048 brian10048 mentioned this pull request Nov 11, 2022
Closed
@Vandan-OSI
Copy link
Contributor Author

@max3903 As per @brian10048 Feedback Do We Still Need a stock_putaway_method module Dependency?

@max3903
Copy link
Member

max3903 commented Mar 13, 2023 •
edited
Loading

@Vandan-OSI @brian10048 The stock_putaway_method module is used to determine the location of the specific vehicle when the location is set to the generic "Vehicles" location. We should be using stock_putaway_hook https://github.com/OCA/stock-logistics-workflow/tree/15.0/stock_putaway_hook to provide the same feature.

@Vandan-OSI Vandan-OSI force-pushed the 15.0-MIG-fieldservice_vehicle_stock branch 3 times, most recently from 109c05d to 4730de6 Compare March 13, 2023 14:42
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 16, 2023
OCA-git-bot and others added 24 commits July 16, 2023 13:55
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.1.1.1
aa41723 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/
@marcelsavegnago @max3903
[FIX] Correcao de dependencias
b513048
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.1.2.0
502e95a
@max3903
[FIX] fieldservice_vehicle_stock: Expected singleton: stock.picking
a061f9e
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.1.2.1
6c70a21 
Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/es/
@max3903
[FIX] fieldservice_vehicle_stock
969ca1e
@max3903
[FIX] fieldservice_vehicle_stock
ddbc387
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.1.2.2
0e845cc 
Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/

Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/es_CL/

Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/pt_BR/

Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/pt_PT/

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/
@brian10048 @max3903
[IMP] fieldservice_vehicle_stock
c56148f 
Minimize dependency on stock_request

[UPD] README.rst
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.2.0.0
182f4fa 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/
@brian10048 @max3903
[FIX] fieldservice_vehicle_stock
56760c8 
File was moved in OCA#675
@OCA-git-bot @max3903
fieldservice_vehicle_stock 12.0.2.0.1
aa8237d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_vehicle_stock/
@max3903
[IMP] fieldservice_vehicle_stock: black, isort, prettier
e1731eb
@max3903
[MIG] fieldservice_vehicle_stock: Migration to 14.0
0a4ffa0
@oca-travis @max3903
[UPD] Update fieldservice_vehicle_stock.pot
642d76c
@OCA-git-bot @max3903
[UPD] README.rst
d127f47
@mymage @max3903
Added translation using Weblate (Italian)
b694afb
@mymage @max3903
Translated using Weblate (Italian)
170ae97 
Currently translated at 95.0% (19 of 20 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_vehicle_stock/it/
@ibuioli @max3903
Added translation using Weblate (Spanish (Argentina))
fc51b14
@ibuioli @max3903
Translated using Weblate (Spanish (Argentina))
0ef5372 
Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_vehicle_stock/es_AR/
@mymage @max3903
Translated using Weblate (Italian)
03f0bf6 
Currently translated at 100.0% (20 of 20 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_vehicle_stock/it/
@brian10048 @max3903
[IMP] fieldservice_vehicle_stock: remove extra dependency
e1e3215
@OCA-git-bot @max3903
fieldservice_vehicle_stock 14.0.1.1.0
b824aee
@Vandan-OSI @max3903
[MIG] fieldservice_vehicle_stock : Migration to 15.0
db0f392
@max3903 max3903 force-pushed the 15.0-MIG-fieldservice_vehicle_stock branch from 4730de6 to db0f392 Compare July 16, 2023 19:55
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@max3903 max3903

Labels
migration needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.