[16.0] [ADD] helpdesk_mgmt_portal_follower: New module

[BernatObrador]

Portal Follower

This module adds the posibilty to add followers to a helpdesk ticket from the helpdesk form at the website portal.

Usage

To make it work you just need to add the emails of the wanted followers to the Add Followers input splitted by comas.

cc https://github.com/APSL 158607

@miquelalzanillas @lbarry-apsl @peluko00 @javierobcn please review

[pedrobaeza]

Please don't use plurals in module names

[peluko00]

LGTM

[lbarry-apsl]

Reviewed. LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[miquelalzanillas]

LGTM.

@pedrobaeza Do you think we can push this?

[pedrobaeza]

Shouldn't this be better called helpdesk_mgmt_portal_follower for better comprehension of the scope? About the feature itself, do you consider safe to allow to add any possible mail to the submitters? I see spam or privacy problems. Also, the term follower for us is well understood, but outside, users (and more through a portal) don't know about it. Maybe you can put the label as "Emails in copy" or similar.

[miquelalzanillas]

Hi @pedrobaeza ,

I'm agree with module name and field labeling. About the security, do you have any idea about how we can improve it? I'm thinking about to add a restriction to only permit new follower adresses where the email domain mathces with the one of the partner assigned to the ticket, but in case of non business domains (gmail, hotmail, outlook, ...) will not have any sense.

[pedrobaeza]

Yeah, indeed it's a rabbit hole. You can put the warning in the ROADMAP and warn your potential users about that, and see how it progresses.

[miquelalzanillas]

Ok, thanks Pedro.

@BernatObrador could you check Pedro's suggestions?

[BernatObrador]

Hi @miquelalzanillas and @pedrobaeza! The name changes and the roadmap have been updated. Thanks so much for your contributions, @pedrobaeza!

[pedrobaeza]

You're welcome. Merging due to existing reviews:

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-612-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 39b4caf. Thanks a lot for contributing to OCA. ❤️