[12.0] contract_operating_unit #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
12.0-add-contract_operating_unit
branch
from
735609a to
fab6640
Compare
AaronHForgeFlow
force-pushed
the
12.0-add-contract_operating_unit
branch
from
fab6640 to
cc6f66b
Compare
kittiu
reviewed
May 28, 2021
| "author": "ForgeFlow S.L., " "Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/operating-unit", | ||
| "category": "Invoicing", | ||
| "depends": ["contract", "operating_unit"], |
There was a problem hiding this comment.
I think this should depends on accounting, otherwise, the invoice created will has no OU ?
Suggested change
| "depends": ["contract", "operating_unit"], | |
| "depends": ["contract", "account_operating_unit"], |
kittiu
reviewed
May 28, 2021
| <record id="contract_contract_form_view" model="ir.ui.view"> | ||
| <field name="name">contract.contract form view (in contract_payment_mode)</field> | ||
| <field name="model">contract.contract</field> | ||
| <field name="inherit_id" ref="contract.contract_contract_form_view" /> |
There was a problem hiding this comment.
Suggested change
| <field name="inherit_id" ref="contract.contract_contract_form_view" /> | |
| <field name="inherit_id" ref="contract.contract.contract_contract_customer_form_view" /> |
Otherwise, OU in supplier invoice will has 2 field,
kittiu
reviewed
May 28, 2021
| <field name="inherit_id" ref="contract.contract_contract_search_view" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="name" position="after"> | ||
| <field name="operating_unit_id" groups="operating_unit.group_multi_operating_unit"/> |
There was a problem hiding this comment.
Should we have group by OU also?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce operating units in contracts.
In previous versions contracts and analytic accounts were the same model. After v12 contracts were refactored to use a new model. Thus, contracts lost operating unit information. This module gets back the operating units in contracts.
@ForgeFlow