Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] contract_operating_unit #382

Merged
merged 11 commits into from
Jun 18, 2021
Merged

[14.0][MIG] contract_operating_unit #382

merged 11 commits into from
Jun 18, 2021

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented May 28, 2021

Standard migration from #263

@kittiu kittiu force-pushed the 14.0-mig-contract_operating_unit branch from 93762bc to a7cadd3 Compare May 28, 2021 04:32
@kittiu kittiu force-pushed the 14.0-mig-contract_operating_unit branch from a7cadd3 to 05a0578 Compare May 28, 2021 04:45
AaronHForgeFlow
AaronHForgeFlow reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional tests succeed.

Nevertheless, could you add a test that checks that the generated invoices belongs to the same OU?

Saran440
Saran440 approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

AaronHForgeFlow
AaronHForgeFlow approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-382-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jun 18, 2021
Closed
16 tasks
@OCA-git-bot OCA-git-bot merged commit 307a761 into OCA:14.0 Jun 18, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2cf54d8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kittiu @OCA-git-bot @AaronHForgeFlow @Saran440