Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] migration of module analytic_operating_unit #331

Merged
merged 15 commits into from
Dec 24, 2020
Merged

[14.0][MIG] migration of module analytic_operating_unit #331

merged 15 commits into from
Dec 24, 2020

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Oct 10, 2020

Proposed changes

I've migrated the module analytic_operating_unit and its functionalities from Odoo 13.0 to 14.0. I've checked if all unit tests are still running.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

Further comments

This module depends on the operating_unit. That means that there should be a migration of it to 14.0. Because there is already a PR for migration I've added the changes of the PR to my local environment to test my migration.

This PR depends on the following migration PR:

#328

@alan196 alan196 mentioned this pull request Oct 10, 2020
Merged
9 tasks
@alan196 alan196 force-pushed the 14.0-mig-analytic_operating_unit branch from 5b15077 to 40bda54 Compare October 15, 2020 21:10
@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Oct 16, 2020
Closed
16 tasks
JordiBForgeFlow and others added 15 commits October 20, 2020 14:12
@JordiBForgeFlow @alan196
analytic_operating_unit
e5781e0
@LoisRForgeFlow @alan196
[MIG] analytic_operating_unit to v10.0
618f665
@gdgellatly @alan196
[11.0] Port analytic operating unit
02357ee
@sudhir-erpharbor @alan196
[MIG]analytic_operating_unit to v12
ee9dc29
@AaronHForgeFlow @alan196
[FIX]security in analytic_operating_unit
d276e86
@oca-travis @alan196
[UPD] Update analytic_operating_unit.pot
1673303
@alan196
[IMP] analytic_operating_unit: black, isort
d95d9d6
@alan196
[IMP] analytic_operating_unit: Migration to V13
7fe69b7
@oca-travis @alan196
[UPD] Update analytic_operating_unit.pot
41c0187
@alan196
Added translation using Weblate (Spanish (Mexico))
42cf553
@alan196
Translated using Weblate (Spanish (Mexico))
98076dc 
Currently translated at 100.0% (2 of 2 strings)

Translation: operating-unit-13.0/operating-unit-13.0-analytic_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-analytic_operating_unit/es_MX/
@OCA-git-bot @alan196
pre-commit update
2dc61af
@MiquelRForgeFlow @alan196
[UPD] Eficent -> ForgeFlow
141d62f
@alan196
[IMP] analytic_operating_unit: black, isort, prettier
ccd956d
@alan196
[MIG] analytic_operating_unit: Migration to 14.0
5b05c5b
@alan196 alan196 force-pushed the 14.0-mig-analytic_operating_unit branch from 40bda54 to 5b05c5b Compare October 20, 2020 19:12
@alan196
Copy link
Contributor Author

alan196 commented Dec 9, 2020

@kittiu could you review this 🙏

@Saran440
Copy link
Member

Functional Test 👍

I have question.
If I config following
Selection_004

Why It filter default OU? Should It filter by OU not default OU? or I mistake something.
Selection_005

@kittiu
Copy link
Member

kittiu commented Dec 10, 2020

LGTM too

@alan196
Copy link
Contributor Author

alan196 commented Dec 10, 2020

Functional Test 👍

I have question.
If I config following
Selection_004

Why It filter default OU? Should It filter by OU not default OU? or I mistake something.
Selection_005

I see an issue here, but it's not from this module it's from module operating_unit, this field has a domain [('user_ids', '=', uid)] in the field, but I see that this field in module operating_unit is only defined when the Operating Unit is created and it will be only the user that creates the OU.

I think is better to change the domain to filter [('id', 'in', user.assigned_operating_unit_ids.ids)]

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kittiu
Copy link
Member

kittiu commented Dec 24, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-331-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c4458db into OCA:14.0 Dec 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0d92916. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 14.0-mig-analytic_operating_unit branch August 12, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@kittiu kittiu kittiu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.