Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] migration of module operating_unit #328

Merged
merged 48 commits into from
Oct 15, 2020
Merged

[14.0][MIG] migration of module operating_unit #328

merged 48 commits into from
Oct 15, 2020

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Oct 10, 2020 •
edited
Loading

Proposed changes

I've migrated the module operating_unit and its functionalities from Odoo 13.0 to 14.0. I've checked if all unit tests are still running.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

sudhir-serpentcs and others added 30 commits October 9, 2020 15:02
@sudhir-serpentcs @alan196
[ADD] Added migrated Operating Unit module for v9.
3b2ea77
@sudhir-serpentcs @alan196
[IMP] Improved the license terms and improved the module standard as …
51b781d 
…per the OCA guidelines.
@sudhir-serpentcs @alan196
[ADD] Renamed README.md to README.rst
ed441a0
@JordiBForgeFlow @alan196
[IMP] Assign multi_ou grup and add OCA logo.
566215b
@JordiBForgeFlow @alan196
[FIX] remove description from __openerp__.py
331994f
@JordiBForgeFlow @alan196
[FIX] Corrections as per review comments
1d87327
@sudhir-serpentcs @alan196
[ADD] Added travis yml file and changed the code as per travis test s…
30c22fc 
…uggestions.
@sudhir-serpentcs @alan196
[IMP] Added name_search to search the OU based on name and code.
510ed95
@JordiBForgeFlow @alan196
[FIX] Review as per @dreispt comments
8cb1074
@JordiBForgeFlow @alan196
[FIX] Review as per travis
6514e53
@JordiBForgeFlow @alan196
[FIX] flake8
6e5464a
@JordiBForgeFlow @alan196
[IMP] improve name_search
527118a
@JordiBForgeFlow @alan196
[IMP] changed readme.rst
7a51135
@JordiBForgeFlow @alan196
[IMP] changed Eficent copyright
588ddb2
@JordiBForgeFlow @alan196
[IMP] removed size from char fields. General improvement to XML style.
d90b049
@pedrobaeza @alan196
[MIG] Make modules uninstallable
84da90e
@pedrobaeza @alan196
[MIG] Rename manifest files
a8a9942
@MiquelRForgeFlow @alan196
[MIG] operating_unit to v10.0 (OCA#45)
ec6b866 
* [MIG] operating_unit to v10.0
@JordiBForgeFlow @alan196
A user can only select the operating units that he is allowed (OCA#59)
d602f6d
@gdgellatly @alan196
Port to v11 - retry
8cd6ab0
@AdriaGForgeFlow @alan196
[12.0][MIG] operating_unit: Migration to v12.0
5f7004f
@OCA-git-bot @alan196
[UPD] README.rst
72a1c07
@AaronHForgeFlow @alan196
[IMP]add user_ids field in operating unit. Useful for accesing in oth…
5e1beda 
…er models
@AaronHForgeFlow @alan196
[UPT]operating_unit roadmap
bbf89f2
@OCA-git-bot @alan196
[UPD] README.rst
1998a9f
@bjeficent @alan196
[FIX] operating_unit: Failing test
579f797
@bjeficent @alan196
[FIX] operating_unit: Creation of OU's failing cause of wrong environ…
96de845 
…ment
@AaronHForgeFlow @alan196
[FIX]clear caches when saving so OU rules are updated
d213dda
@bjeficent @alan196
[FIX] Make company_id readonly to avoid crashes in multi-company envi…
12f9b9f 
…ronments
@OCA-git-bot @alan196
[UPD] README.rst
0d3f7e4
This was referenced Oct 10, 2020
Merged
Closed
Merged
Merged
Merged
@AaronHForgeFlow
Copy link
Contributor

Thank you @alan196 for migrating this to 14.0 🚀

I am wondering if you have looked at this: #312 For me it makes sense what he says. What do you think?

@alan196
Copy link
Contributor Author

alan196 commented Oct 14, 2020

Thank you @alan196 for migrating this to 14.0 🚀

I am wondering if you have looked at this: #312 For me it makes sense what he says. What do you think?

I like the change, do I want to merge that change? or I make a cherry-pick to get this change to V14?

@AaronHForgeFlow
Copy link
Contributor

I think it is best to cherry-pick it. But please wait until commits on the other PR are squashed.

@AaronHForgeFlow
Copy link
Contributor

0743b27 could be cherry-picked now :)

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional test good so far

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-328-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8755af2 into OCA:14.0 Oct 15, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 71d804d. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 14.0-mig-operating_unit branch October 15, 2020 21:04
@francesco-ooops francesco-ooops mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesus01x jesus01x jesus01x approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.