Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] hr_expense_operating_unit #346

Merged
merged 28 commits into from
Jun 3, 2021

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Dec 9, 2020

Standard migration
Depends,

@kittiu kittiu mentioned this pull request Dec 9, 2020
16 tasks
@Saran440
Copy link
Member

@kittiu please, update travis and cherry-pick #360

@kittiu
Copy link
Member Author

kittiu commented Feb 24, 2021

@kittiu please, update travis and cherry-pick #360

Done

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@Saran440
Copy link
Member

cherry-pick #368

@kittiu kittiu force-pushed the 14.0-mig-hr_expense_operating_unit branch from 369fa75 to 4c30683 Compare May 6, 2021 17:09
@AaronHForgeFlow
Copy link
Contributor

It seems there is a bug in the account_operating_unit module, probably because of a change in Odoo standard (a new constraint?). The last commit in 14.0 branch is from January so it is quite old. If nobody proposes a fix I will try to do that soon.

@kittiu
Copy link
Member Author

kittiu commented May 7, 2021

It seems there is a bug in the account_operating_unit module, probably because of a change in Odoo standard (a new constraint?). The last commit in 14.0 branch is from January so it is quite old. If nobody proposes a fix I will try to do that soon.

Done here, #370

@kittiu kittiu changed the title [14.0][MIG] hr_expense_operating_unit [WIP] [14.0][MIG] hr_expense_operating_unit Jun 3, 2021
@kittiu kittiu force-pushed the 14.0-mig-hr_expense_operating_unit branch from 4c30683 to aaee538 Compare June 3, 2021 04:38
@kittiu kittiu force-pushed the 14.0-mig-hr_expense_operating_unit branch from aaee538 to 6017910 Compare June 3, 2021 04:47
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on runbot:
User admin is assigned to all OUs:
image

However it cannot select other but the default OU in hr expense report and expense:
image

I understand I should be able to select any of the OUs I am assign to.

@kittiu
Copy link
Member Author

kittiu commented Jun 3, 2021

If you type it in, it will be found. We also face this, but not the problem of this module may be from base operating_unit itself.

I will check that too.

@AaronHForgeFlow
Copy link
Contributor

Thank you for the update, yes, it not really an issue because you can type and select a different one. And it does not seem an issue in this module.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kittiu
Copy link
Member Author

kittiu commented Jun 3, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-346-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3cff95 into OCA:14.0 Jun 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ddd8c5a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.